Bug 541605 - [View Editor] Generate controls - Different behavior for abstract and concrete classes
Summary: [View Editor] Generate controls - Different behavior for abstract and concret...
Status: RESOLVED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.22.0   Edit
Assignee: Eugen Neufeld CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2018-11-27 10:44 EST by Lucas Koehler CLA
Modified: 2019-07-03 04:59 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Koehler CLA 2018-11-27 10:44:45 EST 
If the root EClass of a View is abstract, the Generate Controls wizard shows all sub classes during the selection of the data element for which controls should be generated. Thereby, all sub classes of the abstract class are shown in a flat list as children of the abstract class. This means, the hierarchy of the sub classes is disregarded.
This behavior is inconsistent with the behavior for concrete classes: No sub classes are shown for concrete classes.

It should be discussed whether this inconsistent behavior is wanted and if not, how it should be fixed.
Comment 1 Eclipse Genie CLA 2019-06-14 11:57:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/144078
Comment 3 Lucas Koehler CLA 2019-06-19 05:24:57 EDT 
As we allow creating view models with an abstract root EClass, the foregoing changes abolishes the different treatment of abstract and concrete EClasses.

The Generate Controls wizard no longer allows to select a base class for the generation but offers all features available for the view's root EClass. Furthermore, it is now possible to generate controls for features which do not have an Item Property Descriptor even if the view's root EClass is concrete (before this only worked for features of abstract EClasses).
Comment 4 Eclipse Genie CLA 2019-07-01 09:36:02 EDT 
New Gerrit change created: https://git.eclipse.org/r/145218
Comment 6 Eclipse Genie CLA 2019-07-01 12:18:02 EDT 
New Gerrit change created: https://git.eclipse.org/r/145230
Comment 8 Eclipse Genie CLA 2019-07-03 04:59:32 EDT 
New Gerrit change created: https://git.eclipse.org/r/145358