541442 – [drag and drop] DND fails when dropping a bordered node on a shadowed container

Bug 541442 - [drag and drop] DND fails when dropping a bordered node on a shadowed container

Summary: [drag and drop] DND fails when dropping a bordered node on a shadowed container

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	5.1.3
Hardware:	PC Windows 10

Importance:	P3 normal (vote)
Target Milestone:	6.1.2
Assignee:	Laurent Fasani
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:	541412
Blocks:
	Show dependency tree

Reported:	2018-11-22 05:37 EST by Laurent Fasani
Modified:	2019-02-15 09:01 EST (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
project to reproduce (4.89 KB, application/x-zip-compressed) 2018-11-22 05:37 EST, Laurent Fasani	no flags	Details
project to reproduce (5.88 KB, application/x-zip-compressed) 2018-11-23 11:27 EST, Laurent Fasani	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Fasani

2018-11-22 05:37:25 EST

Created attachment 276657 [details]
project to reproduce

+++ This bug was initially created as a clone of Bug #541412 +++

Steps to reproduce
* open the attached project and the diagram
* select the IN bordered node from E1 node and drag it onto the shadow of the bottom of E1 node
-> the source feedback(border node) appears whereas the target feedback (E3 node) don't
* drop the bordered element(releasing the left button) 
-> the bordered node is not moved on the feedback area but stays on E1

Comment 1 Laurent Fasani

2018-11-22 05:37:47 EST

Steps to validate
* open the the diagram in the  attached project
* select the IN bordered node from E3 node and drag it onto the shadow of the bottom of E1 node
->there should be no feedback
* drop the bordered element(releasing the left button) 
-> the IN bordered node remains on E3

Comment 2 Laurent Fasani

2018-11-23 11:27:58 EST

Created attachment 276679 [details]
project to reproduce

Comment 3 Eclipse Genie

2018-11-26 04:43:04 EST

New Gerrit change created: https://git.eclipse.org/r/133051

Comment 4 Eclipse Genie

2018-11-26 04:43:07 EST

New Gerrit change created: https://git.eclipse.org/r/133050

Comment 5 Laurent Fasani

2018-11-26 04:44:18 EST

A new bug is linked to the bordered node drag and
When dropping the boredered node from a node to its parent container node, and if zoom is activated, the bordered node source feedback is bad sized and located.

STEPS TO VALIDATE:

Do the Comment 1 scenario

Additional scenario:
* open the the diagram in the  attached project
* select the IN bordered node from E3 (or E1)  node and drag it onto the shadow of the bottom of P0 container
-> there should be no feedback
* move the mouse slightly upward so that the bordered node feeback is displayed
-> the feedback should be located under the mouse and with the same size as the boredered node itself(no unexpected zoom of the node)

Comment 6 Eclipse Genie

2018-11-26 04:50:32 EST

New Gerrit change created: https://git.eclipse.org/r/133053

Comment 7 Eclipse Genie

2018-12-26 11:12:18 EST

Gerrit change https://git.eclipse.org/r/133053 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=46d2ff2a45d83d0499f9bf91e2a84652abf0f577

Comment 8 Eclipse Genie

2018-12-26 11:12:20 EST

Gerrit change https://git.eclipse.org/r/133051 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8ac8d16c27e08badb75daa82c9ab4fabca645ed0

Comment 9 Pierre Guilet

2019-01-28 10:54:02 EST

Verified with OD CE 11.1.2

Comment 10 Pierre-Charles David

2019-02-15 09:01:44 EST

Available in Sirius 6.1.2, see https://wiki.eclipse.org/Sirius/6.1.2 for details.