Bug 541416 - [code mining] Missing code minings in class file editor
Summary: [code mining] Missing code minings in class file editor
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.10   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.10 RC1   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 529127
Blocks:
  Show dependency tree
 
Reported: 2018-11-21 10:53 EST by Dani Megert CLA
Modified: 2018-11-29 04:18 EST (History)
3 users (show)

See Also:
noopur_gupta: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2018-11-21 10:53:26 EST 
Missing code minings in class file editor.
Comment 1 Eclipse Genie CLA 2018-11-21 17:17:56 EST 
New Gerrit change created: https://git.eclipse.org/r/132865
Comment 3 Dani Megert CLA 2018-11-22 11:53:27 EST 
(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/132865

This fixes
> No code minings when opening .class editor 


The major problem is still that binary references aren't shown. This might also be an issue with source files. We can use this bug or open a new one.
Comment 4 Angelo ZERR CLA 2018-11-22 12:02:58 EST 
> The major problem is still that binary references aren't shown. This might also be an issue with source files. We can use this bug or open a new one.

Even if I understand that it appears as a bug, I'm a little afraid with performance if we add this binary search. I'm afraid that codemining will become less responsive.
Comment 5 Noopur Gupta CLA 2018-11-23 01:10:52 EST 
(In reply to Dani Megert from comment #3)
> The major problem is still that binary references aren't shown. This might
> also be an issue with source files. We can use this bug or open a new one.
I have opened bug 541479 for the binary reference count problem.
Comment 6 Dani Megert CLA 2018-11-23 04:05:44 EST 
(In reply to Angelo ZERR from comment #4)
> > The major problem is still that binary references aren't shown. This might also be an issue with source files. We can use this bug or open a new one.
> 
> Even if I understand that it appears as a bug, I'm a little afraid with
> performance if we add this binary search. I'm afraid that codemining will
> become less responsive.

Please comment in bug 541479.
Comment 7 Noopur Gupta CLA 2018-11-29 04:18:17 EST 
Verified as fixed in I20181128-1800.