Community
Participate
Working Groups
Currently if you check "Enable code minings", nothing happens. The user needs to check "Show References" or "Show Implementation" or both manually. A better usability will be by checking "Enable code minings", everything ( including field reference) is selected and the user manually unchecks options he or she doesn't need.
Perhaps a better mean is to enable references and implementation in the default preferences. Imho i think its a bad idea to activate by default on fields because it draws so many information in the editor.two many informations Kill the information
New Gerrit change created: https://git.eclipse.org/r/132856
Please review my very simply gerrit patch https://git.eclipse.org/r/#/c/132856/ Keep in mind that there will have other code minings in this preference page. Developping a custom behaviour (when enabled code mining is checked, it changed enabled of references and implementations) is strange for me. I prefer having default preferences which enable references and implementations by default, but which not work since global enable code mining is disabled by default. The first time, user go at code mining preferences pages and check enable code mining. As references and implementions are checked by default, code minings will appear. Hope you will agree with me.
New Gerrit change created: https://git.eclipse.org/r/132866
(In reply to Eclipse Genie from comment #4) > New Gerrit change created: https://git.eclipse.org/r/132866 Ignore this gerrit change (132866) as my patch is identical and has thus been abandoned in lieu of Angelo's.
(In reply to Angelo ZERR from comment #1) > Imho i think its a bad idea to activate by default on > fields because it draws so many information in the editor.two many > informations Kill the information I would also prefer to keep references on fields off by default. But Vikas and Dani prefer to have everything enabled when enabling the code minings feature. So, we can keep the field references on by default and can look into changing the default if requested by other users also.
Is https://git.eclipse.org/r/132856 follows your idea?
Gerrit change https://git.eclipse.org/r/132856 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=cf06059a975abc71973b463ffceb83b86e18ede8
(In reply to Angelo ZERR from comment #7) > Is https://git.eclipse.org/r/132856 follows your idea? Along with that, I have enabled field references also by default: https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=eb5b6f701974388ef7a472068f5b6fa050bc26ef
+1 for RC1.
verified on Version: 2018-12 (4.10) Build id: I20181125-0600
