Bug 541406 - [code mining] Allow to set color and styles for code mining text (see Syntax Coloring page)
Summary: [code mining] Allow to set color and styles for code mining text (see Syntax ...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.10   Edit
Hardware: All All
: P3 enhancement with 4 votes (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 529127
Blocks:
  Show dependency tree
 
Reported: 2018-11-21 10:11 EST by Dani Megert CLA
Modified: 2022-03-28 00:55 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2018-11-21 10:11:32 EST 
[code mining] Allow to set color and styles for code mining text (see Syntax Coloring page)

There are two possible ways to fix this:
- For now only allow to set the color and use this for all kinds of editors
  --> Text Editors preference page
- Add it to the Java -> Editor -> Syntax Coloring preference page
Comment 1 Dani Megert CLA 2018-11-21 10:55:49 EST 
I think we should also change the default color so that it does not use the same color as annotations.
Comment 2 Mickael Istria CLA 2018-11-21 11:20:52 EST 
IIRC, the color is chosen, independently of JDT, to be the same as line-numbers as those are also "annotaitons" in the sense that they are not part of the textual payload, so it seemed consistent to use the same color.
I suggest that maybe we also consider whether it would make sense to change the color of the Java annotations which carry a lot of meaning these days and would probably deserve a stronger color.
Comment 3 Mickael Istria CLA 2018-11-21 18:41:34 EST 
Dani, what's the scope here? Only JDT editor (and bug should be retargeted to JDT) or code minings in general (in which case it could be a dup of 532359 )?
Comment 4 Dani Megert CLA 2018-11-23 12:24:38 EST 
(In reply to Mickael Istria from comment #3)
> Dani, what's the scope here? Only JDT editor (and bug should be retargeted
> to JDT) or code minings in general (in which case it could be a dup of
> 532359 )?

For me the most important thing is the color.

Most likely this will have to be per editor type as every editor uses different color schemes. So, fine to move to JDT,
Comment 5 Mickael Istria CLA 2018-11-23 12:51:35 EST 
(In reply to Dani Megert from comment #4)
> Most likely this will have to be per editor type as every editor uses
> different color schemes. So, fine to move to JDT,

Are editors (is JDT) able to customize the line number color?
Comment 6 Dani Megert CLA 2018-11-23 12:54:08 EST 
(In reply to Mickael Istria from comment #5)
> (In reply to Dani Megert from comment #4)
> > Most likely this will have to be per editor type as every editor uses
> > different color schemes. So, fine to move to JDT,
> 
> Are editors (is JDT) able to customize the line number color?

No, but this is not really relevant since those are not inside the text of the editor.
Comment 7 Juergen Baier CLA 2022-03-25 18:22:27 EDT 
I agree that changing color, size and font style would be super-useful. The current default looks too similar to the regular Java code.