Bug 541383 - module deprecation may not be detected against SourceModuleBinding
Summary: module deprecation may not be detected against SourceModuleBinding
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.10   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug bulk move
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-20 18:12 EST by Stephan Herrmann CLA
Modified: 2023-02-28 04:29 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2018-11-20 18:12:19 EST
ModuleDeclaration.analyseModuleGraph(CompilationUnitScope) may not detect that a required SourceModuleBinding is deprecated, because ensureAnnotationsResolved() may not have run at that point in time.

To wit: use Deprecated9Test.testBug533063_2() (as proposed via https://git.eclipse.org/r/#/c/132799/) remove the line this.moduleMap.clear() and watch the test fail.

Insert requiredModule.getAnnotationTagBits() before asking isDeprecated() and see it pass again. Could such a call influence compilation order in unwanted ways?

In fact, SourceModuleBinding.isDeprecated() may want to call ensureAnnotationsResolved() for good measure.
Comment 1 Manoj N Palat CLA 2019-08-27 02:05:49 EDT
Bulk move out of 4.13
Comment 2 Eclipse Genie CLA 2023-02-28 04:29:12 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.