541273 – ssh: support reading PuTTY key files (*.ppk) in the Apache MINA sshd ssh client

Bug 541273 - ssh: support reading PuTTY key files (*.ppk) in the Apache MINA sshd ssh client

Summary: ssh: support reading PuTTY key files (*.ppk) in the Apache MINA sshd ssh client

Status:	CLOSED WONTFIX

Alias:	None

Product:	JGit
Classification:	Technology
Component:	JGit (show other bugs)
Version:	5.2
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	---
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:	520927 541425 548080
Blocks:
	Show dependency tree

Reported:	2018-11-17 16:26 EST by Thomas Wolf
Modified:	2020-03-18 04:48 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thomas Wolf

2018-11-17 16:26:00 EST

Apache MINA sshd has a sshd-putty component for reading PuTTY key files.

Include it in Orbit (CQs...) and then use it in the JGit Apache MINA sshd ssh client. Should be as simple as registering the key readers in addition to the existing ones.

Comment 1 Thomas Wolf

2018-11-21 16:57:26 EST

This will have to wait until either:

* Platform also moves to sshd 2.0.0 and includes sshd-contrib and sshd-scp
  in Orbit, or
* we move to sshd >= 2.1.0 and include sshd-putty in Orbit

The separate sshd-putty artifact exists only since 2.1.0; before it was in sshd-contrib, where other code has a dependency on sshd-scp.

Comment 2 Matthias Sohn

2019-06-09 06:02:20 EDT

Filed CQ for sshd-putty 2.2.0
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20150 for JGit and 
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20151 for Orbit

Comment 3 Thomas Wolf

2019-06-12 17:40:08 EDT

CQ 20150 is in state "awaiting_committer". Shouldn't it be returned to the IP Team after the artifacts have been attached? Or does that happen when it's +1'ed by Chris (PMC)?

Comment 4 Matthias Sohn

2019-06-12 17:46:20 EDT

missed to forward the CQ to the IP team, did this now

Comment 5 Eclipse Genie

2019-06-30 12:18:25 EDT

New Gerrit change created: https://git.eclipse.org/r/145187

Comment 6 Eclipse Genie

2019-07-29 16:58:47 EDT

New Gerrit change created: https://git.eclipse.org/r/146758

Comment 7 Eclipse Genie

2019-07-29 17:30:35 EDT

New Gerrit change created: https://git.eclipse.org/r/146760

Comment 8 Thomas Wolf

2020-03-18 04:48:32 EDT

Turns out we cannot do this inside the ssh.apache library in JGit; it'd force the putty dependency on all clients.

Doing it for EGit only in the EGitSshdSessionFactory would be possible, but there's no user request for it. Doing it only in EGit might require setting up a unit test infrastructure for this feature in EGit. Or test the feature in JGit even though it'd be implemented in EGit.

So for now we drop this, also due to capacity constraints. If it should ever be needed, [1] shows what would have to be done. Some tests in JGit also exist in [2].

[1] https://git.eclipse.org/r/#/c/146760/1/org.eclipse.egit.core/src/org/eclipse/egit/core/internal/EGitSshdSessionFactory.java
[2] https://git.eclipse.org/r/#/c/146758/