Bug 541052 - DOT Graph View - add support for rendering styles
Summary: DOT Graph View - add support for rendering styles
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF DOT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 5.1.0 (2019-06)   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-12 15:41 EST by Tamas Miklossy CLA
Modified: 2019-05-25 02:19 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot about the current rendering (113.28 KB, image/png)
2018-11-12 15:41 EST, Tamas Miklossy CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Miklossy CLA 2018-11-12 15:41:19 EST 
Created attachment 276553 [details]
Screenshot about the current rendering

The DOT Graph View should render clusters with color attribute values properly.

Example:

graph {
  subgraph cluster_0 {
  color=green
    1
  }
}
Comment 1 Zoey Gerrit Prigge CLA 2019-05-24 10:48:02 EDT 
Hi Tamás,

As bug #541106 has closed, should we extend this bug to also include style (no bug yet) and penwidth (bug closed with general implementation support (for nodes and edges))?

We have discussed refactoring/extracting the style calculations from Dot2ZestAttributes converter into a NodeStyleUtil to reuse them for Cluster display.

If we go along with a Cluster Node Style Util, these changes would then be implemented at once.

Thanks.
Comment 2 Tamas Miklossy CLA 2019-05-25 01:38:11 EDT 
Hello Zoey!

I like your suggestion, I rename this bug accordingly.
Comment 3 Tamas Miklossy CLA 2019-05-25 01:40:33 EDT 
I merged your PR into the master branch. Resolving as fixed in 5.1.0 (2019-06).