Bug 540697 - Unnecessary report of deleted file.
Summary: Unnecessary report of deleted file.
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 6.1.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-11-01 16:12 EDT by Ed Willink CLA
Modified: 2018-12-06 05:41 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2018-11-01 16:12:13 EDT
If the model file source of a diagram is deleted, the exception below is logged.

What's the point? Perhaps you could provide a do you want to restore wizard, but in the log. Just clean up.

Much better if there wasn't a bloated *.aird file. One diagram file per model file would enable the user to retain control just like earlier tooling did.

Thread [Worker-3: Loading models] (Suspended (exception Resource$IOWrappedException))	
	PlatformResourceURIHandlerImpl$WorkbenchHelper.createPlatformResourceInputStream(String, Map<?,?>) line: 221	
	PlatformResourceURIHandlerImpl.createInputStream(URI, Map<?,?>) line: 525	
	ExtensibleURIConverterImpl.createInputStream(URI, Map<?,?>) line: 360	
	XMLmodelResourceImpl(ResourceImpl).load(Map<?,?>) line: 1314	
	XtextResourceSet(ResourceSetImpl).demandLoad(Resource) line: 259	
	XtextResourceSet(ResourceSetImpl).demandLoadHelper(Resource) line: 274	
	ResourceSetImpl$MappedResourceLocator(ResourceSetImpl$ResourceLocator).demandLoadHelper(Resource) line: 804	
	ResourceSetImpl$MappedResourceLocator.getResource(URI, boolean) line: 1204	
	XtextResourceSet(ResourceSetImpl).getResource(URI, boolean) line: 352	
	XtextResourceSet.getResource(URI, boolean) line: 236	
	DAnalysisImpl.getResource(ResourceSet, URI) line: 226	
	DAnalysisImpl.getModels() line: 198	
	SessionResourcesTracker.resolveAllSemanticResourcesFromModels(Collection<DAnalysis>) line: 214	
	SessionResourcesTracker.initialize(IProgressMonitor) line: 93	
	DAnalysisSessionImpl$2.doExecute() line: 1183	
	DAnalysisSessionImpl$2(RecordingCommand).execute() line: 135	
	EMFCommandOperation.doExecute(IProgressMonitor, IAdaptable) line: 119	
	EMFCommandOperation(AbstractEMFOperation).execute(IProgressMonitor, IAdaptable) line: 150	
	DefaultOperationHistory.execute(IUndoableOperation, IProgressMonitor, IAdaptable) line: 491	
	WorkspaceCommandStackImpl.doExecute(Command, Map<?,?>) line: 208	
	WorkspaceCommandStackImpl(AbstractTransactionalCommandStack).execute(Command, Map<?,?>) line: 165	
	WorkspaceCommandStackImpl(AbstractTransactionalCommandStack).execute(Command) line: 219	
	DAnalysisSessionImpl.open(IProgressMonitor) line: 1186	
	SessionManagerImpl.openSession(URI, IProgressMonitor, UICallBack, boolean) line: 396	
	OpenRepresentationsFileJob.performOpenSession(IProgressMonitor) line: 192	
	OpenRepresentationsFileJob.runInWorkspace(IProgressMonitor) line: 161	
	OpenRepresentationsFileJob(InternalWorkspaceJob).run(IProgressMonitor) line: 42	
	Worker.run() line: 63
Comment 1 Ed Willink CLA 2018-11-01 16:59:37 EDT
The problem persists after a repair, whioh removes the dead diagram elements, but not the semantic reference to the deleted file in <semanticResources> and <ownedRepresentationDescriptors
Comment 2 Florian Barbin CLA 2018-12-06 05:41:01 EST
The resource removing is handled if the Sirius Session is opened.
We should also handle the case where the resource has been removed with closed session.