Community
Participate
Working Groups
The fix for 527016 set all PDE builders to run even on empty deltas to avoid the computation of delta trees for large deltas. For workspaces with many projects (~750 in our case) this is a major performance issue, as commented on 527016 as well. At least for us the small delta use case (a manual change to a file) is the vast majority of deltas. Large deltas happen when rebasing (etc.), which is acceptable (IMHO) to take a little longer. Small deltas must be as fast as possible. Reverting https://git.eclipse.org/r/#/c/111258/ locally immediately returns our Eclipse to a working state (i.e. autobuild after changing a single file takes <1 second vs. >30 seconds).
New Gerrit change created: https://git.eclipse.org/r/131658
(In reply to Eclipse Genie from comment #1) > New Gerrit change created: https://git.eclipse.org/r/131658 Bug 527016 comment 7 says "the effect is minimal", so I would also agree to revert to the old state, since it can cause such critical regressions like here. @Karsten: any objections?
> @Karsten: any objections? No, sounds reasonable. My bad.
Gerrit change https://git.eclipse.org/r/131658 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=3b18435a0262f52ee5504f6554dfc6cbb20d6268
Thanks, Markus!
