Bug 540555 - Compatibility error in launch configuration with 4.9 using Java 12
Summary: Compatibility error in launch configuration with 4.9 using Java 12
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.9   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.10 M3   Edit
Assignee: Sarika Sinha CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 539570
Blocks: 531843
  Show dependency tree
 
Reported: 2018-10-29 02:58 EDT by Sarika Sinha CLA
Modified: 2018-11-22 02:02 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2018-10-29 02:58:47 EDT 
Bug 531843 added the support to allow future java versions.
But it is no longer working with 4.9 and Java 12.
Comment 1 Sarika Sinha CLA 2018-10-29 03:01:21 EDT 
Looks like it was previously working luckily with compilance.compare to.
After it was changed to JavaCore.compareJavaVersions the comparison result in value > 1 which throws the error.
Comment 2 Sarika Sinha CLA 2018-10-29 04:38:25 EDT 
Adding the code to support future versions, It will work after the fix for JavaCore.compareJavaVersions(vmver, latest)  is released (mostly via Bug 531713).
Comment 3 Eclipse Genie CLA 2018-10-29 04:58:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/131580
Comment 4 Jay Arthanareeswaran CLA 2018-10-29 05:16:56 EDT 
Raised bug 540560 to discuss the API's shortcoming.
Comment 6 Sarika Sinha CLA 2018-10-31 02:58:23 EDT 
Merged to Java 12 also, Jay you can test your fix.
Comment 7 Jay Arthanareeswaran CLA 2018-11-02 05:14:56 EDT 
Things are working as expected with the latest Y build.
Comment 8 Sarika Sinha CLA 2018-11-13 04:03:10 EST 
(In reply to Jay Arthanareeswaran from comment #7)
> Things are working as expected with the latest Y build.

Needs to work for I build as well!!
Comment 9 Jay Arthanareeswaran CLA 2018-11-20 00:12:07 EST 
Sarika, I believe this is addressed via bug 539570.

Can you please confirm?
Comment 10 Sarika Sinha CLA 2018-11-20 00:32:52 EST 
(In reply to Jay Arthanareeswaran from comment #9)
> Sarika, I believe this is addressed via bug 539570.
> 
> Can you please confirm?

Yes, Jay.
Comment 11 Jay Arthanareeswaran CLA 2018-11-20 00:41:54 EST 

*** This bug has been marked as a duplicate of bug 539570 ***
Comment 12 Sarika Sinha CLA 2018-11-22 01:27:59 EST 
There were two parts to the fix!! 
One part resolved via Bug bug 539570.

Marking duplicate to another component makes it really difficult to resolve verify and track in the case of future failures.
Comment 13 Sarika Sinha CLA 2018-11-22 02:02:49 EST 
Verified using
Eclipse SDK

Version: 2018-12 (4.10)
Build id: I20181121-1800

While testing found Bug 541432.