Bug 539898 - [Staging] Staging view should not interfere with my commit message
Summary: [Staging] Staging view should not interfere with my commit message
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-07 15:29 EDT by Wim Jongman CLA
Modified: 2018-10-08 10:52 EDT (History)
1 user (show)

See Also:


Attachments
Git staging view anomalies (50.88 KB, image/png)
2018-10-07 15:31 EDT, Wim Jongman CLA
no flags Details
Preference for hardwrapping of commit messages (73.06 KB, image/png)
2018-10-08 10:52 EDT, Jonas Hungershausen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Jongman CLA 2018-10-07 15:29:48 EDT
It seems that the Staging view enforces a maximum line length and then inserts a line break. This is intrusive. Text wrapping looks strange. 

See the effect of creating long lines in the attached screenshot.

I do acknowledge the various styles that are being used [1][2] but I would like to see a more friendly implementation. 

Proposals:
1. Add a rule to the Staging view preferences with default e.g. 50/72
2. Let the user write long lines with automatic wrapping

When committing, the text will be split according to the active rule and when re-displaying (e.g. when amending) then the text will be combined again. I believe we can use the RFC3676 as an inspiration to make this happen. [3]


[1] https://chris.beams.io/posts/git-commit/
[2] https://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting
[3] https://www.ietf.org/rfc/rfc3676.txt
Comment 1 Wim Jongman CLA 2018-10-07 15:31:09 EDT
Created attachment 276154 [details]
Git staging view anomalies
Comment 2 Jonas Hungershausen CLA 2018-10-08 10:52:34 EDT
You can disable the hard wrapping in the preferences: Team->Git->Committing
See attachment.

I would suggest changing the default so that it doesn't automatically wrap the lines in the editor though.
Comment 3 Jonas Hungershausen CLA 2018-10-08 10:52:59 EDT
Created attachment 276169 [details]
Preference for hardwrapping of commit messages