Community
Participate
Working Groups
Hi GitHub PR: https://github.com/eclipse/openj9-website/pull/120 First time contribution for Paul. When it failed first time he looked at his Eclipse profile and added his GitHub ID, which had been missing. All subsequent attempts give us "Validation status unavailable. Contact support." Looking at and comparing profile setup at Eclipse and at GitHub doesn't show any obvious issues, so wondering if the first failed attempt has left something bad. Pauls Eclipse a/c: pcheesemanb43 email: paul.cheeseman@uk.ibm.com Please advise. Many thanks Sue (OpenJ9 committer)
Hi I've not received a response to this bugzilla, but today Paul closed his PR and started with a new udpate. This time, the pull request worked and was merged. The corresponding mirror job to update Eclipse GIT website repo failed because he didn't have a gerrit account. Think this is the 3rd time we've hit this issue. I got him to sign in to gerrit for the first time, assuming that this would be fixed, but we are still unable to mirror. Similar bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=538343 Please can someone look into this please. Thanks Sue
I have a similar problem with a PR for the N4JS project. PR https://github.com/eclipse/n4js/pull/932 with "ip-validation — The pull request did not pass Eclipse validation. The following users have invalid Signed-off-by footers: katrinleinweber" It is a rather old PR, I tried to solve it (by clicking on "Details"), then got the "Current status Validation status unavailable. Contact support." message, hoped that this will be a temporary outage and forgot about it. According to the contributer, she did sign an ECA. Did she do something wrong or is it an Eclipse infrastructure problem? Or can I do something about that?
I believe this won't be an issue with the new version of the ECA Validation service which we are working on with Bug 540694 - Github IP validation needs to be more robust.
(In reply to Christopher Guindon from comment #3) > I believe this won't be an issue with the new version of the ECA Validation > service which we are working on with Bug 540694 - Github IP validation needs > to be more robust. I'm not sure if this will resolve the issue in Sue's second comment. AFAIK, the issue is that contributors to the openj9-website repo must create (sign-in) an Eclipse Gerrit account in order for their change to get mirrored to the Eclipse Git repo.
(In reply to Adam Brousseau from comment #4) > (In reply to Christopher Guindon from comment #3) > > I believe this won't be an issue with the new version of the ECA Validation > > service which we are working on with Bug 540694 - Github IP validation needs > > to be more robust. > > I'm not sure if this will resolve the issue in Sue's second comment. AFAIK, > the issue is that contributors to the openj9-website repo must create > (sign-in) an Eclipse Gerrit account in order for their change to get > mirrored to the Eclipse Git repo. True, our Gerrit and our Github ECA validation hooks are separate.
Closing this bug since I believe that the initial problem with the Github Validation hook was fixed with our new App. Please open a separate bug against Gerrit if you are still experiencing issues with that service!
Christopher >Closing this bug since I believe that the initial problem with the Github Validation hook was fixed with our new App. >Please open a separate bug against Gerrit if you are still experiencing issues with that service! This bug is about the Gerrit validation hook - always hsa been. I'd like this to remain open because it is still an issue for us. Does it need component field updating? Thanks Sue
(In reply to Sue Chaplain from comment #7) > Christopher > > > >Closing this bug since I believe that the initial problem with the Github Validation hook was fixed with our new App. > > >Please open a separate bug against Gerrit if you are still experiencing issues with that service! > > > This bug is about the Gerrit validation hook - always hsa been. I'd like > this to remain open because it is still an issue for us. Does it need > component field updating? > > Thanks > Sue I am confused since your first comment refers to a github pull request. I will re-open and move it to Gerrit.
So the issue is with the pipeline https://github.com/eclipse/openj9-website/blob/master/jenkinsMirror, correct? This pipeline tries to push commit from the github repo https://github.com/eclipse/openj9-website to git.eclipse.org/www.eclipse.org/openj9 As you already mentioned in other bugs, I don't see any easy solution to be able to keep the original commits in this case, without forcing contributor to log into gerrit first :/ One solution would be to adopt the same strategy as the one you use in https://github.com/eclipse/openj9-website/blob/master/jenkinsPullRequests, i.e., copy the content of the commit from https://github.com/eclipse/openj9-website currently being built to the git.eclipse.org/www.eclipse.org/openj9. All commits in this last repo will then be from genie.openj9, but I guess this is not too bad, as you still have the full history, with correct contributor in github. WDYT?
Yes that would be an option. A bit of a bandaid solution and bit more work with more possibility for failure. If there's no solution for the Gerrit account issue then I guess this is our best option then.
One solution may also be to ditch completely git repo on gerrit and use your repo @ github as the source for the website. @Webmaster, is this doable? I know a at least half a dozen project that would be glad to use github only (incl. for their website).
(In reply to Mikaël Barbero from comment #11) > @Webmaster, is this doable? Currently our tooling is not capable of supporting the use of repos outside of git.eclipse.org for website content. -M.
(In reply to Eclipse Webmaster from comment #12) > (In reply to Mikaël Barbero from comment #11) > > > @Webmaster, is this doable? > > Currently our tooling is not capable of supporting the use of repos outside > of git.eclipse.org for website content. > > -M. Matt, Mikaël and I had a meeting about this last week and we've decided to patch the Gerrit validation plugin to address this issue. The validation is currently failing because the author does exist in the Gerrit database. We will patch the validation plugin to create the missing "Gerrit" account if the author has a valid Eclipse Account.
This is good news. Thanks for proceeding with this.
I am upping the priority of this bug since this might stop some contributors to submit code to our project!
This is now live on production. It's now possible to push a Gerrit review where the author does not exist in the Gerrit database.
Closing.
