Bug 539826 - BranchLabel: return value of delegate.forwardReference*() ignored
Summary: BranchLabel: return value of delegate.forwardReference*() ignored
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.8.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.24 M2   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-05 03:57 EDT by Andrey Loskutov CLA
Modified: 2022-04-11 09:22 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2018-10-05 03:57:45 EDT 
The fix added in bug 114894 was incomplete, because it had a stupid programming error in BranchLabel: return value of delegate.forwardReference*() was ignored.

We should fix it.
Comment 1 Andrey Loskutov CLA 2018-10-05 03:59:19 EDT 
I will push a patch in a moment
Comment 2 Stephan Herrmann CLA 2018-10-06 07:00:15 EDT 
From looking at the code, the bug & fix are obvious. However, I failed to see a difference resulting from the proposed fix: I took the first test in SwitchTest that exercises this change (which happened to be testSideEffect()) and compared produced byte code: I could not find any difference.
Do you have a test case where this code change does have an effect?
Comment 3 Andrey Loskutov CLA 2018-10-06 08:09:18 EDT 
Stephan, please check my last comment on the original bug.
Comment 4 Manoj N Palat CLA 2019-02-11 03:57:36 EST 
Bulk move out of 4.11
Comment 5 Eclipse Genie CLA 2021-02-01 03:45:08 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Andrey Loskutov CLA 2022-04-11 09:22:16 EDT 
Merged via https://github.com/eclipse-jdt/eclipse.jdt.core/pull/3