Bug 539799 - Discussion: Have an initially selected repository in Staging, Reflog
Summary: Discussion: Have an initially selected repository in Staging, Reflog
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-04 13:46 EDT by Michael Keppler CLA
Modified: 2018-11-12 15:02 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2018-10-04 13:46:31 EDT
After workbench startup the Staging and Reflog view (and maybe others) are initialized with "No repository selected", requiring the user to select a repo to be able to use those views. I see multiple alternatives how to improve that situation:

a) Always take the first repository (from the repository view) as initial repository in the other views.
b) Only if there is exactly 1 repository in the repo view, take it as the initial repository in the other views.
c) Remember the current repository for each view on shutdown and restore that initial selection on re-creation of the view.

For me, C seems to bring the most benefit (but also the most implementation work, probably). Any preferences (or additional suggestions) from others?
Comment 1 Thomas Wolf CLA 2018-10-04 15:15:31 EDT
If at all, then (c).
Comment 2 Matthias Sohn CLA 2018-10-04 17:46:26 EDT
c) could make sense. Not sure if this is worth the effort in order to safe a single click.

If another team provider is used for some project it gets more complex
Comment 3 Eclipse Genie CLA 2018-11-02 15:46:46 EDT
New Gerrit change created: https://git.eclipse.org/r/131871
Comment 4 Eclipse Genie CLA 2018-11-10 10:47:38 EST
Gerrit change https://git.eclipse.org/r/131871 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=c7940ec94c58879eefe5e74d21e8621b09a438d6
Comment 5 Eclipse Genie CLA 2018-11-12 06:13:59 EST
New Gerrit change created: https://git.eclipse.org/r/132274
Comment 6 Eclipse Genie CLA 2018-11-12 14:02:23 EST
Gerrit change https://git.eclipse.org/r/132274 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=7089ad43b89ba53f8df28fccbfb17938da2a6ea9
Comment 7 Thomas Wolf CLA 2018-11-12 14:08:39 EST
@Michael: was there anything more you had in mind, or shall we consider this done?
Comment 8 Michael Keppler CLA 2018-11-12 15:02:29 EST
While I initially aimed at _always_ having an initial repository selected, I think the current implementation with tracking all kinds of selection is sufficient for now. I also have to experience it a bit more in practice. :)