Bug 539653 - [EMF Forms] Viewmodel generation does not handle non-ascii chars
Summary: [EMF Forms] Viewmodel generation does not handle non-ascii chars
Status: RESOLVED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.18.0   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 1.19.0   Edit
Assignee: Lucas Koehler CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 542746 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-30 03:21 EDT by Akira Tanaka CLA
Modified: 2018-12-20 05:28 EST (History)
2 users (show)

See Also:

Attachments
Description of the issue using diagrams (525.47 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2018-09-30 03:21 EDT, Akira Tanaka CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Akira Tanaka CLA 2018-09-30 03:21:51 EDT 
Created attachment 276071 [details]
Description of the issue using diagrams

Please see attached file for description with diagrams.
Comment 1 Eugen Neufeld CLA 2018-10-04 06:54:18 EDT 
From the docx:
In my previous post to the forum (https://www.eclipse.org/forums/index.php/m/1787606/), I wrote I exported the viewmodel file, and saved it as UTF-8 document with external editor, then imported back/replaced original, and it worked.  But this time (with the latest release) it did not work.  Since I see no issue regarding UTF-8 handling in EMF part, I suspect somewhere in the code (EMF Forms or ECP) that generates viewmodel (xxxx.view file) you may have code fragment that assumes ascii only, which I could not pinpoint and need somebody’s help.

Yes there seems to be a problem with handling UTF-8 when generating the view model.
We will check this.
Comment 2 Eclipse Genie CLA 2018-11-20 04:33:19 EST 
New Gerrit change created: https://git.eclipse.org/r/132736
Comment 4 Lucas Koehler CLA 2018-11-22 07:51:04 EST 
In order to guarantee compatibility of view models to Ecore models which use non-ASCII characters, we enforce saving view models as UTF-8 in EMF Forms. This is done by explicitly setting the encoding to UTF-8 whenever we save a resource containing a view model.
Besides supporting UTF-8 encoded Ecore models, this also allows using non-ASCII characters in view models (e.g. for labels or the name of a table column).
Comment 5 Lucas Koehler CLA 2018-12-20 05:28:41 EST 
*** Bug 542746 has been marked as a duplicate of this bug. ***