Bug 539611 - MultiReference Renderer should sort based on displayed labels
Summary: MultiReference Renderer should sort based on displayed labels
Status: RESOLVED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.19.0   Edit
Assignee: Lucas Koehler CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2018-09-28 05:15 EDT by Lucas Koehler CLA
Modified: 2018-11-07 11:36 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Koehler CLA 2018-09-28 05:15:30 EDT 
The MultiReferenceSWTRenderer should sort the referenced objects based on their labels shown in the table viewer (which has exactly one column showing the labels).
The current sorting is not intuitive as it does not use the displayed labels. Consequently, the sorting appears to be arbitrary.
Comment 1 Eclipse Genie CLA 2018-09-28 05:25:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/130126
Comment 3 Jonas Helming CLA 2018-11-06 11:30:54 EST 
@Lucas: Isn't the "test" tag missing here?
Comment 4 Lucas Koehler CLA 2018-11-07 11:36:29 EST 
TEST INFORMATION
Summary of the critical part of the change
The ordering of objects shown by the Multi Reference SWT Renderer changed. When sorting, the objects are now sorted by their displayed label. 

Potential regressions
Before this change, the objects were sorted by their String representation. Now they are sorted by their label. While sorting based on the label should be more intuitive for the user, sorting by the String representation could be preferable in special use cases.

Affected areas / use cases
Sorting objects showed by the Multi Reference Renderer.

Things that shall be tested
That the sorting behaves as expected.