Community
Participate
Working Groups
Created attachment 275986 [details] screenshot 1. Open the history view 2. Do not select any commit in the view 3. Right click on the column headers. The context menu contains a "copy commit id" entry. It should not be visible, since there is no selection. If the menu item is used, there is no content in the clipboard.
I think the action should be shown but disabled if there is no selection
New Gerrit change created: https://git.eclipse.org/r/130034
(In reply to Matthias Sohn from comment #1) > I think the action should be shown but disabled if there is no selection Why should it be shown?
you are right, since there is only a single action which doesn't make sense when there is no selection, no context menu should be shown at all. I was thinking about a menu where some entries cannot be used due to some property of the selected item, in this case it helps users to always show all the actions to be expected on this type of item and disable the ones which cannot be used for the selected item since it makes users aware of the available actions for this item type. But in this case there is only a single action, and when no item is selected there is no such thing like an item type so what I said earlier doesn't make sense.
Gerrit change https://git.eclipse.org/r/130034 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=139b78cda2797f1024b4c35a8b8ac70aa6bb0406
