Bug 539053 - [11] Fix regressions in eclipse.jdt.core-run.javac-11 vis-a-vis run.javac-10
Summary: [11] Fix regressions in eclipse.jdt.core-run.javac-11 vis-a-vis run.javac-10
Status: REOPENED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.9   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.24   Edit
Assignee: Manoj N Palat CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: regression
Depends on:
Blocks: 536270
  Show dependency tree
 
Reported: 2018-09-14 03:00 EDT by Manoj N Palat CLA
Modified: 2024-02-08 06:12 EST (History)
0 users

See Also:


Attachments
Test results (3.00 MB, text/plain)
2018-09-16 17:38 EDT, Stephan Herrmann CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manoj N Palat CLA 2018-09-14 03:00:18 EDT
Follow up of review in bug 535918 comment 12 :

Trying to run affected tests back-to-back with javac it seems that our tests are not ready for this exercise?

I got: java.lang.RuntimeException: unknown raw javac version: 11
	at org.eclipse.jdt.core.tests.compiler.regression.AbstractRegressionTest$JavacCompiler.minorFromRawVersion(AbstractRegressionTest.java:390)

Looks like this can be easily fixed by a new stanza in org.eclipse.jdt.core.tests.compiler.regression.AbstractRegressionTest.JavacCompiler.JavacCompiler(String, String) 

Do we have an open bug for that kind of adjustments in tests?

FYI, I'm using these additional VM args:
-ea -Drun.javac=enabled -Djdk.root=/home/java/jdk-11 -Dcompliance=11

Are we ready to rededicate [1] to Java 11? Or should I create an additional Job?

[1] https://ci.eclipse.org/jdt/job/eclipse.jdt.core-run.javac-10/
Comment 1 Eclipse Genie CLA 2018-09-14 03:03:32 EDT
New Gerrit change created: https://git.eclipse.org/r/129399
Comment 3 Stephan Herrmann CLA 2018-09-15 17:21:28 EDT
Sorry, but ParserTest is not yet ready to run on 11, see https://ci.eclipse.org/jdt/job/eclipse.jdt.core-run.javac-11/3/testReport/org.eclipse.jdt.core.tests.compiler.parser/ParserTest/test001___11/

More of the same seems to be needed.


Additionally, failures in JEP181NestTest seem to indicate we don't run our test programs on JRE 11, see e.g. https://ci.eclipse.org/jdt/job/eclipse.jdt.core-run.javac-11/3/testReport/org.eclipse.jdt.core.tests.compiler.regression/JEP181NestTest/testBug535918_001a___11/

Or, the used jre would not be able to handle access among nest mates?? Tests claim to be using this version:
openjdk version "11-ea" 2018-09-25
OpenJDK Runtime Environment 18.9 (build 11-ea+23)
OpenJDK 64-Bit Server VM 18.9 (build 11-ea+23, mixed mode)

(interesting date "2018-09-25")

According to build logs, this is the command line by which our tests are executed:

/opt/public/common/java/oracle/jdk-11_x64-latest/bin/java, -Dosgi.noShutdown=false, -Dosgi.os=linux, -Dosgi.ws=gtk, -Dosgi.arch=x86_64, --add-modules, ALL-SYSTEM, -Drun.javac=enabled, -Djdk.root=/shared/common/java/openjdk/jdk-11_x64-latest/, -Dcompliance=11, -Dosgi.clean=true, -jar, /jobs/genie.jdt/eclipse.jdt.core-run.javac-11/workspace/.repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.5.100.v20180827-1352/org.eclipse.equinox.launcher-1.5.100.v20180827-1352.jar, -data, /jobs/genie.jdt/eclipse.jdt.core-run.javac-11/workspace/org.eclipse.jdt.core.tests.compiler/target/work/data, -install, /jobs/genie.jdt/eclipse.jdt.core-run.javac-11/workspace/org.eclipse.jdt.core.tests.compiler/target/work, -configuration, /jobs/genie.jdt/eclipse.jdt.core-run.javac-11/workspace/org.eclipse.jdt.core.tests.compiler/target/work/configuration, -application, org.eclipse.tycho.surefire.osgibooter.headlesstest, -testproperties, /jobs/genie.jdt/eclipse.jdt.core-run.javac-11/workspace/org.eclipse.jdt.core.tests.compiler/target/surefire.properties

Running just JEP181NestTest locally from Eclipse (with run.javac=enabled) is green.

Any ideas?
Comment 4 Manoj N Palat CLA 2018-09-16 11:36:47 EDT
@Stephan:  I see this error with JEP181Test with ea18 where the nestmates are not supported but with ea+23 this error goes away as this version supports nestmate. I am running the tests with 28 now with all green on a local run, for  ParserTest and JEP181Test as green. Can you please try with build 28?
Comment 5 Stephan Herrmann CLA 2018-09-16 13:42:37 EDT
(In reply to Manoj Palat from comment #4)
> @Stephan:  I see this error with JEP181Test with ea18 where the nestmates
> are not supported but with ea+23 this error goes away as this version
> supports nestmate. I am running the tests with 28 now with all green on a
> local run, for  ParserTest and JEP181Test as green. Can you please try with
> build 28?

Locally, I see the same, but jenkins disagrees. 

Filed bug 539122 for what I guess to be the cause of confusion.
Comment 6 Stephan Herrmann CLA 2018-09-16 17:38:41 EDT
Created attachment 275839 [details]
Test results

While jenkins cannot yet provide the results, PFA the results from running tests.compiler.regression locally against javac11.

Please see that against javac10 we currently have approx. 230 failures [1], whereas the attached result lists 328 failures!

Some differences might be due to fixes in master which are not yet in BETA_JAVA11.  

At least JEP181NestTest is listed in green :)


[1] https://ci.eclipse.org/jdt/job/eclipse.jdt.core-run.javac-10/43/testReport/
Comment 7 Stephan Herrmann CLA 2018-10-02 16:50:12 EDT
We do have our first results from our Jenkins job testing back-to-back with javac11:
https://hudson.eclipse.org/jdt/job/eclipse.jdt.core-run.javac-11/9/testReport/

At this point it shows 256 failures vs. the approx. 230 failures against javac10 (with a little fluctuation between builds). Apparently, merging master & BETA_JAVA11 helped to reduce the failures.

@Manoj, I would be great if you could identify and analyse the remaining difference.

I suggest you start by comparing the "All Tests" summaries in
https://hudson.eclipse.org/jdt/job/eclipse.jdt.core-run.javac-10/46/testReport/org.eclipse.jdt.core.tests.compiler.regression/
https://hudson.eclipse.org/jdt/job/eclipse.jdt.core-run.javac-11/9/testReport/org.eclipse.jdt.core.tests.compiler.regression/
Comment 8 Stephan Herrmann CLA 2018-10-19 17:13:28 EDT
setting a more realistic (=future) target.
Comment 9 Stephan Herrmann CLA 2018-11-27 06:11:00 EST
Adjusting the title, since the infra-structure issues have been resolved, but we are left with new failures at 11.
Comment 10 Manoj N Palat CLA 2019-02-11 03:57:21 EST
Bulk move out of 4.11
Comment 11 Manoj N Palat CLA 2019-02-11 04:16:13 EST
Bulk move out of 4.11
Comment 12 Manoj N Palat CLA 2019-05-20 04:44:48 EDT
missed this due to less bandwidth again - hope to reduce the failures in 4.13 in incrementally (or decr?) - moving to 4.13
Comment 13 Manoj N Palat CLA 2019-11-25 10:49:09 EST
Bulk move out of 4.14
Comment 14 Manoj N Palat CLA 2021-02-19 05:27:45 EST
Bulk move out of 4.19
Comment 15 Manoj N Palat CLA 2021-05-21 00:09:42 EDT
Bulk move out of 4.20
Comment 16 Jay Arthanareeswaran CLA 2021-11-19 01:21:29 EST
Bulk move out of 4.22.

If this is going to make it to 4.22, feel free to set the target back.
Comment 17 Manoj N Palat CLA 2022-02-16 05:12:43 EST
Bulk move out of 4.23
Comment 18 Eclipse Genie CLA 2024-02-08 06:12:48 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.