Bug 538933 - [ELK] Manhattan edge property is lost after using an ELK layout
Summary: [ELK] Manhattan edge property is lost after using an ELK layout
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 6.0.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-09-11 09:52 EDT by Yvan Lussaud CLA
Modified: 2018-11-13 09:34 EST (History)
2 users (show)

See Also:


Attachments
project to reproduce (146.29 KB, application/x-zip-compressed)
2018-10-15 10:35 EDT, Pierre Guilet CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yvan Lussaud CLA 2018-09-11 09:52:40 EDT
The Manhattan property should be preserved after using an ELK layout.
Comment 1 Pierre Guilet CLA 2018-10-15 10:35:50 EDT
Created attachment 276246 [details]
project to reproduce
Comment 2 Pierre Guilet CLA 2018-10-15 10:51:49 EDT
To reproduce:

-import the model and design project
-launch a runtime and import the sample project
-click on the arrange all button on tabbar.

KO the layouting does not produce manhattan edges whereas this style is specified in the odesign.

The layout algorithm used is ELK Mr Tree.

Layout algorithms are made to get optimum results for particular kind of representations. The edges aspect is a part of these algorithms.

Some ELK algorithms like ELK layered have an option for edges style. But some others don't have this option.

For those that don't have this option, doing a pass on the layouting result that have not taken in consideration the style during its computing could break the good graphical aspect of it . I am not sure it is a good idea.

For those that have this option, we could do a bridge between VSM edge style definition and the option available in ELK algorithm. The problem is that the option in ELK algorithms are applied for all edges whereas with the VSM we specify the edge style at a mapping level.

I am not sure that it is relevant to be able to specify edges style at a mapping level in VSM for autmatic layout algorithms such as ELK.
Comment 3 Pierre Guilet CLA 2018-11-13 09:34:07 EST
The following case can be handled.
If the ELK layout pass is producing visually orthogonal edges that can be considered as manhattan but are not, We transform those to manhattan style if the edge segments have strictly the same size.