Bug 538810 - dispose() is never called for details pane for hover
Summary: dispose() is never called for details pane for hover
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.6   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-07 14:36 EDT by Larry Barowski CLA
Modified: 2022-09-25 12:31 EDT (History)
1 user (show)

See Also:


Attachments
zipped plugin project that demonstrates the problem (9.12 KB, application/x-zip-compressed)
2018-09-07 14:36 EDT, Larry Barowski CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Larry Barowski CLA 2018-09-07 14:36:08 EDT
Created attachment 275748 [details]
zipped plugin project that demonstrates the problem

IDetailPane.dispose() is never called for a detail pane in the hover for source code variables during Java debugging.

The control for the detail pane is disposed, but not immediately when the hover window closes. It will be disposed when the next hover window is shown, when an "inspect" window closes, and probably at other times. This can be used to mitigate the problem.

We are using detail panes that can update in the background (at debugger breakpoint, step, suspend) and not just though IDetailPane.display(). Updates for these can take significant time, so having even one unused/invisible active detail pane is troublesome.

For the "inspect" window, there is no problem, dispose() is called as soon as the window closes. The hover window should work the same way.

A test project is attached. Debug as an Eclipse Application, debug anything in the target and stop at a breakpoint. Try hovering over an initialized variable and also try using "inspect" on the same. Check console output. You will see that dispose() is never called for the hover detail panes, and dispose on the control is not called immediately when the hover window closes.
Comment 1 Andrey Loskutov CLA 2018-09-07 14:39:38 EDT
Patch is welcome. I guess this is not a regression in 4.8, the code must be much older.
Comment 2 Eclipse Genie CLA 2020-09-10 19:44:34 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 3 Eclipse Genie CLA 2022-09-25 12:31:25 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.