Bug 538637 - JIPP for jta
Summary: JIPP for jta
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: CI-Jenkins (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P1 blocker (vote)
Target Milestone: ---   Edit
Assignee: CI Admin Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-05 06:33 EDT by Tom Jenkinson CLA
Modified: 2018-10-02 06:59 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Jenkinson CLA 2018-09-05 06:33:41 EDT
Requesting a CI instance to CI/CD https://github.com/eclipse-ee4j/jta-api
Comment 1 Dmitry Kornilov CLA 2018-09-11 05:55:50 EDT
Webmasters, please address this issue. It was submitted 6 days ago and there is still no progress. It's blocking us.
Comment 2 Frederic Gurr CLA 2018-09-11 06:30:06 EDT
We had to address some issues that kept us from provisioning JIPPs on the new infra. This issues are now resolved, and we will work trough the backlog of JIPP requests.

Thanks for your patience.
Comment 3 Dmitry Kornilov CLA 2018-09-11 06:58:51 EDT
(In reply to Frederic Gurr from comment #2)
> We had to address some issues that kept us from provisioning JIPPs on the
> new infra. This issues are now resolved, and we will work trough the backlog
> of JIPP requests.
> 
> Thanks for your patience.

Thanks for quick reply, Frederic!
Comment 4 Tom Jenkinson CLA 2018-09-13 10:20:19 EDT
As per https://github.com/eclipse-ee4j/jsonp/wiki/JSONP-release-job
I would also like to request:
* OSSRH space for project and access permissions
* GPG plugin setup
Comment 5 Dmitry Kornilov CLA 2018-09-13 10:45:10 EDT
Frederic, please give priority to this issue.
Comment 6 Frederic Gurr CLA 2018-09-13 12:33:16 EDT
We will provision a JIPP for jta early next week.
Comment 7 Tom Jenkinson CLA 2018-09-14 07:13:03 EDT
Regarding plugins, I believe I need at least SSH agent one so that the key for the github repo can be injected so that it can tag and push to GitHub please.
Comment 8 Tom Jenkinson CLA 2018-09-14 08:06:49 EDT
And I would like the following additional plugin please:
* GitHub Pull Request Builder
Comment 9 Mikaël Barbero CLA 2018-09-18 14:11:02 EDT
Provisioning is in progress...
Comment 10 Mikaël Barbero CLA 2018-09-18 14:42:54 EDT
The jta JIPP is now setup at https://jenkins.eclipse.org/jta/

Committers should now be able to login and create jobs. Please note that you will need to login with your _email_ address as your username.

GitHub PullRequest builder and SSH agent have been installed. If you require additional plugins feel free to comment on this bug and list them.

Next up (next week according to our schedule https://docs.google.com/spreadsheets/d/1O2NA6YddYQy34riTabQd_lkNwwFzKq1HevxCJYNXrv4/edit?usp=sharing):
- GPG signing
- OSSRH setup
- GitHub write access
Comment 11 Tom Jenkinson CLA 2018-09-19 04:42:08 EDT
Thanks!
I managed to create a job but it failed with an error saying:

ERROR: Maven Home /opt/tools/apache-maven/latest doesnt exist

https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api/1/console

I assumed Maven would be available by default but it seems not so please may I request the following:
* Maven
* JDK

Hopefully the latest supported of each should be OK.
Comment 12 Tom Jenkinson CLA 2018-09-19 07:29:03 EDT
Another issue I am having is that when using the GitHub Pull Request Builder it seems it doesn't have credentials to add a comment:
https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api/3/console
Comment 13 Frederic Gurr CLA 2018-09-19 10:23:19 EDT
(In reply to Tom Jenkinson from comment #11)
> Thanks!
> I managed to create a job but it failed with an error saying:
> 
> ERROR: Maven Home /opt/tools/apache-maven/latest doesnt exist
> 
> https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api/1/console
> 
> I assumed Maven would be available by default but it seems not so please may
> I request the following:
> * Maven
> * JDK
> 
> Hopefully the latest supported of each should be OK.
We're on it.
Comment 14 Frederic Gurr CLA 2018-09-19 10:26:02 EDT
(In reply to Tom Jenkinson from comment #12)
> Another issue I am having is that when using the GitHub Pull Request Builder
> it seems it doesn't have credentials to add a comment:
> https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api/3/console
GitHub write access is not setup yet. It's scheduled to be set up next week (see comment 10).
Comment 15 Tom Jenkinson CLA 2018-09-19 11:33:32 EDT
(In reply to Frederic Gurr from comment #14)
> (In reply to Tom Jenkinson from comment #12)
> > Another issue I am having is that when using the GitHub Pull Request Builder
> > it seems it doesn't have credentials to add a comment:
> > https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api/3/console
> GitHub write access is not setup yet. It's scheduled to be set up next week
> (see comment 10).

Sorry, I hadn't fully appreciated that the "commenter" - needed that but understood now thanks.
Comment 16 Mikaël Barbero CLA 2018-09-19 13:43:17 EDT
(In reply to Tom Jenkinson from comment #11)
> Thanks!
> I managed to create a job but it failed with an error saying:
> 
> ERROR: Maven Home /opt/tools/apache-maven/latest doesnt exist
> 
> https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api/1/console
> 
> I assumed Maven would be available by default but it seems not so please may
> I request the following:
> * Maven
> * JDK
> 
> Hopefully the latest supported of each should be OK.

The default configuration was wrong, sorry about that. It should be fixed now. Please try again.
Comment 17 Tom Jenkinson CLA 2018-09-20 05:52:04 EDT
Thanks, the maven is working now.
Comment 18 Mikaël Barbero CLA 2018-09-25 05:44:52 EDT
Which Maven groupId(s?) this project is(are?) using? javax.transaction?
Comment 19 Tom Jenkinson CLA 2018-09-25 07:42:19 EDT
(In reply to Mikaël Barbero from comment #18)
> Which Maven groupId(s?) this project is(are?) using? javax.transaction?

There is a requirement to change the groupId as per:
https://github.com/eclipse-ee4j/jta-api/pull/7/files

So it should be:
<groupId>jakarta.transaction</groupId>
<artifactId>jakarta.transaction-api</artifactId>
Comment 20 Mikaël Barbero CLA 2018-09-25 08:59:22 EDT
I've triggered the creation of your OSSRH repositories https://issues.sonatype.org/browse/OSSRH-42899
Comment 21 Tom Jenkinson CLA 2018-09-26 05:48:33 EDT
Thanks, I see the OSSRH is resolved so I assume I have to do some maven settings to be able to do the deploy?

Also is GitHub provisioning and GPG is still on target for this week?

Thanks for your help so far!
Comment 22 Mikaël Barbero CLA 2018-09-26 05:49:28 EDT
I still have to do some configuration for both github and ossrh. The target is still this week. Thanks for your patience.
Comment 23 Mikaël Barbero CLA 2018-09-29 12:40:54 EDT
https://issues.sonatype.org/browse/OSSRH-42899 is now resolved. 

I've configured you JIPP to let it sign artifacts with GGP and publish to Maven central. Note to do that, you will need to follow instructions over here https://wiki.eclipse.org/EE4J_Build

Next up: GitHub write access.
Comment 24 Mikaël Barbero CLA 2018-09-30 17:29:16 EDT
Your JIPP is now fully configured. 

Credentials for writing to GitHub have been added to your JIPP instance.
Comment 25 Tom Jenkinson CLA 2018-10-01 09:56:00 EDT
The GitHub Pull Request Builder seems to only have the option to have "Anonymous connection" and so it isn't commenting on the pull.
Comment 26 Tom Jenkinson CLA 2018-10-01 10:13:09 EDT
Also, I have just started getting:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project jakarta.transaction-api: Fatal error compiling: tools.jar not found: /opt/java/openjdk/jre/../lib/tools.jar

e.g. https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api/13/console
Comment 27 Tom Jenkinson CLA 2018-10-01 10:41:41 EDT
I managed to solve the tools.jar issue but I still can't get the bot to comment on the PRs
Comment 28 Mikaël Barbero CLA 2018-10-01 10:44:49 EDT
(In reply to Tom Jenkinson from comment #27)
> I managed to solve the tools.jar issue 

For my own education what did you do?

> but I still can't get the bot to
> comment on the PRs

I'm having a look.
Comment 29 Tom Jenkinson CLA 2018-10-01 11:06:16 EDT
(In reply to Mikaël Barbero from comment #28)
> (In reply to Tom Jenkinson from comment #27)
> > I managed to solve the tools.jar issue 
> 
> For my own education what did you do?

It was the fact that I was using the "system" version of the JDK rather than a specific one. I think there could have been some kind of a change in the infrastructure there (maybe as part of a JDK 11 upgrade?) anyway I fixed on JDK 8 now.

> 
> > but I still can't get the bot to
> > comment on the PRs
> 
> I'm having a look.


Thanks - I have a slighly different message when I use SSH agent:
https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api-pulls/17/consoleFull
Comment 30 Tom Jenkinson CLA 2018-10-01 11:07:43 EDT
Actually - it might not be different but it is an error message - thanks for looking.
Comment 31 Mikaël Barbero CLA 2018-10-01 12:22:14 EDT
My bad, I forgot to configure the credentials for the GitHub Pull Request builder plugin. Please try again.
Comment 32 Tom Jenkinson CLA 2018-10-01 12:28:21 EDT
(In reply to Mikaël Barbero from comment #31)
> My bad, I forgot to configure the credentials for the GitHub Pull Request
> builder plugin. Please try again.


https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api-pulls/20/console

it didn't seem to make a difference sorry :(
Comment 33 Mikaël Barbero CLA 2018-10-01 16:47:25 EDT
did you try with removing your username from the "Admin list"?
Comment 34 Tom Jenkinson CLA 2018-10-01 17:24:02 EDT
I (In reply to Mikaël Barbero from comment #33)
> did you try with removing your username from the "Admin list"?

I didn't yet - do you think that will help? I have removed by user name from the list but the build has not triggered yet.

But doesn't it seem to be more something like the bot hasn't got the write permission? 

GitHub pull request #8 of commit 146d0e3f6f0ce9be3a83b9e31ee2bebbd3bfb445, no merge conflicts.
Setting status of 146d0e3f6f0ce9be3a83b9e31ee2bebbd3bfb445 to PENDING with url https://jenkins.eclipse.org/jta/job/eclipse-ee4j_jta-api-pulls/21/ and message: 'Build started for merge commit.'
FileNotFoundException means that the credentials Jenkins is using is probably wrong. Or the user account does not have write access to the repo.
org.kohsuke.github.GHFileNotFoundException: {"message":"Not Found","documentation_url":"https://developer.github.com/v3/repos/statuses/#create-a-status"}
	at org.kohsuke.github.Requester.handleApiError(Requester.java:686)
	at org.kohsuke.github.Requester._to(Requester.java:293)
	at org.kohsuke.github.Requester.to(Requester.java:234)
	at org.kohsuke.github.GHRepository.createCommitStatus(GHRepository.java:1075)
	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.createCommitStatus(GhprbSimpleStatus.java:283)
	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.onBuildStart(GhprbSimpleStatus.java:195)
	at org.jenkinsci.plugins.ghprb.GhprbBuilds.onStarted(GhprbBuilds.java:144)
	at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onStarted(GhprbBuildListener.java:20)
	at hudson.model.listeners.RunListener.fireStarted(RunListener.java:240)
	at hudson.model.Run.execute(Run.java:1811)
	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)
Caused by: java.io.FileNotFoundException: https://api.github.com/repos/eclipse-ee4j/jta-api/statuses/<SHA>
	at sun.reflect.GeneratedConstructorAccessor226.newInstance(Unknown Source)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1944)
	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1939)
	at java.security.AccessController.doPrivileged(Native Method)
	at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1938)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1508)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:263)
	at org.kohsuke.github.Requester.parse(Requester.java:612)
	at org.kohsuke.github.Requester.parse(Requester.java:594)
	at org.kohsuke.github.Requester._to(Requester.java:272)
	... 11 more
Caused by: java.io.FileNotFoundException: https://api.github.com/repos/eclipse-ee4j/jta-api/statuses/<SHA>	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1890)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:347)
	at org.kohsuke.github.Requester.parse(Requester.java:602)
	... 13 more

I did find this: https://stackoverflow.com/questions/28481771/github-pull-request-builder-fails-due-to-java-io-filenotfoundexception
Comment 35 Mikaël Barbero CLA 2018-10-01 17:27:46 EDT
(In reply to Tom Jenkinson from comment #34)
> I (In reply to Mikaël Barbero from comment #33)
> > did you try with removing your username from the "Admin list"?
> 
> I didn't yet - do you think that will help? I have removed by user name from
> the list but the build has not triggered yet.
> 
> But doesn't it seem to be more something like the bot hasn't got the write
> permission? 
> 

I triple check that the bot is part of the JTA GitHub team, and the team has write permission on the repo. So it should not be an issue. I will investigate more tomorrow. Thanks for your patience.
Comment 36 Tom Jenkinson CLA 2018-10-01 17:39:13 EDT
(In reply to Mikaël Barbero from comment #35)
> (In reply to Tom Jenkinson from comment #34)
> > I (In reply to Mikaël Barbero from comment #33)
> > > did you try with removing your username from the "Admin list"?
> > 
> > I didn't yet - do you think that will help? I have removed by user name from
> > the list but the build has not triggered yet.
> > 
> > But doesn't it seem to be more something like the bot hasn't got the write
> > permission? 
> > 
> 
> I triple check that the bot is part of the JTA GitHub team, and the team has
> write permission on the repo. So it should not be an issue. I will
> investigate more tomorrow. Thanks for your patience.

Interestingly removing my name from the list of admins and adding into the white list instead seems to have made it work - I can't understand it but it must be something to do with the plugin.

Thanks!
Comment 37 Mikaël Barbero CLA 2018-10-02 06:59:22 EDT
the configuration of the plugin is far from intuitive. You could also try to grant access to all people in organization eclipse-ee4j.