538197 – Sorting og numerical values in table is lexicographical

Bug 538197 - Sorting og numerical values in table is lexicographical

Summary: Sorting og numerical values in table is lexicographical

Status:	RESOLVED FIXED

Alias:	None

Product:	ECP
Classification:	Modeling
Component:	EMF Forms (show other bugs)
Version:	1.17.0
Hardware:	PC Windows 10

Importance:	P2 normal (vote)
Target Milestone:	1.20.0
Assignee:	Lucas Koehler
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:
Blocks:

Reported:	2018-08-23 05:46 EDT by Nikola Veber
Modified:	2018-12-20 11:11 EST (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Screenshot of bug reproduction, table with numerical field. (2.31 KB, image/png) 2018-08-23 05:46 EDT, Nikola Veber	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nikola Veber

2018-08-23 05:46:59 EDT

Created attachment 275500 [details]
Screenshot of bug reproduction, table with numerical field.

When numbers are displayed in table, sorting on that column happens lexicographically.

sorting number 0, 1, 1000, and 2 would result in 
0
1
1000
2

instead of 
0
1
2
1000


I have checked for integer type. Possibly other numerical types are affected as well.

Comment 1 Eugen Neufeld

2018-11-06 04:35:59 EST

Thank you for the report.
We currently don't have time to fix this, but we would be happy to accept a contribution for this.

Comment 2 Eclipse Genie

2018-12-12 12:19:27 EST

New Gerrit change created: https://git.eclipse.org/r/133946

Comment 3 Eclipse Genie

2018-12-20 06:30:11 EST

Gerrit change https://git.eclipse.org/r/133946 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=55405f38fd9207a3ffd2ba1e42071d708a6fa511

Comment 4 Eclipse Genie

2018-12-20 09:36:13 EST

New Gerrit change created: https://git.eclipse.org/r/134338

Comment 5 Eclipse Genie

2018-12-20 10:59:02 EST

Gerrit change https://git.eclipse.org/r/134338 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=867447cdf1f12229c96108f911dfb965fa9cc697

Comment 6 Lucas Koehler

2018-12-20 11:11:55 EST

The sorting in tables was fixed to use the natural comparator for columns whose value type implements the Comparator interface. For all other columns, the sorting by the values' toString representations is still available.