Community
Participate
Working Groups
Created attachment 275357 [details] Breadcrumbs in Linux GTK3 When selecting methods in inner classes the breadcrumb toolbar seems to have problem in drawing the inner class element with proper background and height. Please see the screenshot for more details. This happens on both windows and linux.
Created attachment 275358 [details] Breadcrumb windows
Which build are you using?
Version : 2018-09 M2 (4.9.0M2) Build ID: 20180809-1157
Does it work when you use 4.8: http://download.eclipse.org/eclipse/downloads/drops4/R-4.8-201806110500/
Created attachment 275440 [details] Screenshot under Ubuntu 18.04 Looks fine to me under Ubuntu 18.04. See screenshot.
(In reply to Lars Vogel from comment #5) > Created attachment 275440 [details] > Screenshot under Ubuntu 18.04 > > Looks fine to me under Ubuntu 18.04. See screenshot. Try with a inner class method line in my screenshot. For me also a normal class scenario works. Even in the inner class when this happens open a dialog like launch configurations and close it, the breadcrumbs will be drawn correctly until you move to a different inner class method. Sorry i couldn't add this level of details in the original description.
We need a detailed test case or steps to reproduce this.
Created attachment 275447 [details] BreadcrumIssue.java
Steps to reproduce 1. Open eclipse workbench with a java project. 2. Make sure the "Toggle Breadcrumb" is off. 3. Open BreadcrumIssue.java in the java project 4. Now move the cursor to inside the method "eclipse.BreadcrumbIssue.CrumbListener.onChange()" 5. Now toggle the "Toggle Breadcrumb". 6. Now you should see something similar to "Breadcrumbs in Linux GTK3" attachment.
Another way to reprocude 1. Move the cursor to "eclipse.BreadcrumbIssue.foo()" in the "BreadcrumIssue.java" file. 2. Now toggle on the "Toggle Breadcrumb". 3. Now move the cursor to "eclipse.BreadcrumbIssue.CrumbListener.onChange()" 4. Now you should see something similar to "Breadcrumbs in Linux GTK3" attachment.
I had a look at the issue. I cannot find the cause of this. I assume that this issue existed before but was hidden by the gradient image that was drawn as background of the widgets in https://git.eclipse.org/r/#/c/46712/11/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/breadcrumb/BreadcrumbViewer.java Can someone help here?
Can this be a CSS Styling issue ? I had seen this kind if behavior when certain elements are not styled properly when i was developing my own dark theme for eclipse.
New Gerrit change created: https://git.eclipse.org/r/128087
New Gerrit change created: https://git.eclipse.org/r/128104
New Gerrit change created: https://git.eclipse.org/r/128105
(In reply to Eclipse Genie from comment #13) > New Gerrit change created: https://git.eclipse.org/r/128087 Thank you Gayan. This is a good catch. I moved your changed into JDT's CSS file. As I am not a comitter of JDT i could not amend to your change - sorry.
(In reply to Eclipse Genie from comment #15) > New Gerrit change created: https://git.eclipse.org/r/128105 I also made a corresponding change to the adapted copy of the breadcrumb in platform.debug.
can we pls. get these two fixes (JDT and Platform) into RC1?
Gerrit change https://git.eclipse.org/r/128105 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=bc32c6e27775ccac32ad9db9540f470acb15896c
Thanks, Gayan and Matthias. As I'm also not a JDT committer, I asked Sarika to review the JDT patch.
Gerrit change https://git.eclipse.org/r/128104 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=425eabc8117f6cda6ff6490efde44481237ba33a
Thanks Gayan and Matthias!! +1 for RC1.
Approved for RC1
Verified using Eclipse SDK Version: 2018-09 (4.9) Build id: I20180829-2000
