Bug 537756 - API tools no longer works with JRE < 10
Summary: API tools no longer works with JRE < 10
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.9   Edit
Hardware: PC Windows 7
: P3 blocker (vote)
Target Milestone: 4.9 M3   Edit
Assignee: Mat Booth CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-07 07:46 EDT by Vikas Chandra CLA
Modified: 2018-08-08 05:45 EDT (History)
5 users (show)

See Also:


Attachments
Log from local mvn clean verify in pde.ui (9.21 KB, application/octet-stream)
2018-08-07 09:03 EDT, Alexander Kurtakov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vikas Chandra CLA 2018-08-07 07:46:45 EDT
java.lang.Exception: Could not find plugin "org.eclipse.pde.api.tools.tests"

org.eclipse.test.EclipseTestRunner$TestFailedException: java.lang.Exception: Could not find plugin "org.eclipse.pde.api.tools.tests"
at org.eclipse.test.EclipseTestRunner.runFailed(EclipseTestRunner.java:625)
at org.eclipse.test.EclipseTestRunner.getTest(EclipseTestRunner.java:579)
at org.eclipse.test.EclipseTestRunner.<init>(EclipseTestRunner.java:562)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:344)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:38)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:34)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
Comment 1 Vikas Chandra CLA 2018-08-07 07:47:33 EDT
Also I don't see API tools related preference pages.
Comment 2 Alexander Kurtakov CLA 2018-08-07 08:13:43 EDT
Let's wait for I20180807-0350 results before investigating.
Comment 4 Dani Megert CLA 2018-08-07 08:44:05 EDT
(In reply to Vikas Chandra from comment #1)
> Also I don't see API tools related preference pages.

How can that be? Is there an exception in the .log?
Comment 5 Alexander Kurtakov CLA 2018-08-07 08:53:38 EDT
Which preference pages are missing for you ? I have API baselines|Errors/warnings|Use scans.
Comment 6 Alexander Kurtakov CLA 2018-08-07 09:03:40 EDT
Created attachment 275304 [details]
Log from local mvn clean verify in pde.ui
Comment 7 Alexander Kurtakov CLA 2018-08-07 09:04:16 EDT
(In reply to Alexander Kurtakov from comment #6)
> Created attachment 275304 [details]
> Log from local mvn clean verify in pde.ui

So yes, it's coming from asm update according to this log.
Comment 8 Dani Megert CLA 2018-08-07 09:04:31 EDT
(In reply to Alexander Kurtakov from comment #5)
> Which preference pages are missing for you ? I have API
> baselines|Errors/warnings|Use scans.

Same here with I20180807-0350 and also I20180806-2000.

Vikas?
Comment 9 Alexander Kurtakov CLA 2018-08-07 09:21:50 EDT
For the record - apitools run fine with Java 10 on my machine. So the latest asm update introduced this dependency on Java 9.
Comment 10 Dani Megert CLA 2018-08-07 09:26:42 EDT
(In reply to Alexander Kurtakov from comment #9)
> For the record - apitools run fine with Java 10 on my machine. So the latest
> asm update introduced this dependency on Java 9.

I can confirm that API Tools no longer works with JRE < 10. This is a no go. JRE 8 is a supported target platform for 4.9.
Comment 11 Alexander Kurtakov CLA 2018-08-07 09:28:23 EDT
Probably same reason as bug 537751.
Comment 12 Stephan Herrmann CLA 2018-08-07 11:28:02 EDT
Could this also be the reason behind today's failures in jdt-core-gerrit?

16:23:34 [INFO] Command line:
16:23:34 	[/opt/public/common/jdk1.8.0_x64-latest/jre/bin/java, -jar, /jobs/genie.jdt/eclipse.jdt.core-Gerrit/workspace/.repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.5.100.v20180611-1436/org.eclipse.equinox.launcher-1.5.100.v20180611-1436.jar, -install, /jobs/genie.jdt/eclipse.jdt.core-Gerrit/workspace/org.eclipse.jdt.annotation/target/eclipserun-work, -configuration, /jobs/genie.jdt/eclipse.jdt.core-Gerrit/workspace/org.eclipse.jdt.annotation/target/eclipserun-work/configuration, -data, target/apibuild-workspace, -application, org.eclipse.ant.core.antRunner, -buildfile, target/.apibuild.xml]
16:23:34 Picked up JAVA_TOOL_OPTIONS: -Xmx2G -Djava.io.tmpdir=/tmp/genie.jdt
16:23:35 Buildfile: target/.apibuild.xml
16:23:35 
16:23:35 apigen:
16:23:36 
16:23:36 BUILD FAILED
16:23:36 /jobs/genie.jdt/eclipse.jdt.core-Gerrit/workspace/org.eclipse.jdt.annotation/target/.apibuild.xml:10: Problem: failed to create task or type apitooling.apigeneration
16:23:36 Cause: The name is undefined.
16:23:36 Action: Check the spelling.
16:23:36 Action: Check that any custom tasks/types have been declared.
16:23:36 Action: Check that any <presetdef>/<macrodef> declarations have taken place.

(from https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Gerrit/1109/console )
Comment 13 Eclipse Genie CLA 2018-08-07 12:33:22 EDT
New Gerrit change created: https://git.eclipse.org/r/127160
Comment 14 Mat Booth CLA 2018-08-07 12:49:20 EDT
(In reply to Stephan Herrmann from comment #12)
> Could this also be the reason behind today's failures in jdt-core-gerrit?
> 
> 
> (from https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Gerrit/1109/console )

Yes, I see the same in the gerrit build for the change I submitted above to fix this mess: 

https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator-Gerrit/470/console

Which I suppose means the I-build repo used by tycho-eclipse-run-plugin is broken:

http://download.eclipse.org/eclipse/updates/4.9-I-builds/I20180807-0350/

Alex/Dani:

Is there any chance we can black-list that I-build?

Or must we temporarily hard-code the "eclipserun-repo" in the parent pom?
Comment 16 Alexander Kurtakov CLA 2018-08-07 14:20:24 EDT
(In reply to Mat Booth from comment #14)
> (In reply to Stephan Herrmann from comment #12)
> > Could this also be the reason behind today's failures in jdt-core-gerrit?
> > 
> > 
> > (from https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Gerrit/1109/console )
> 
> Yes, I see the same in the gerrit build for the change I submitted above to
> fix this mess: 
> 
> https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator-
> Gerrit/470/console
> 
> Which I suppose means the I-build repo used by tycho-eclipse-run-plugin is
> broken:
> 
> http://download.eclipse.org/eclipse/updates/4.9-I-builds/I20180807-0350/
> 
> Alex/Dani:
> 
> Is there any chance we can black-list that I-build?

I've marked the bug as unstable which removes it from the composite I-build repo.

> 
> Or must we temporarily hard-code the "eclipserun-repo" in the parent pom?

No, don't do that it should be fine now.
Comment 18 Vikas Chandra CLA 2018-08-08 04:20:31 EDT
Verified comment#0 and comment#1 on
Version: 4.9
Build id: I20180807-2000
Comment 19 Dani Megert CLA 2018-08-08 05:45:49 EDT
(In reply to Vikas Chandra from comment #18)
> Verified comment#0 and comment#1 on
> Version: 4.9
> Build id: I20180807-2000

Also verified with that build.