Community
Participate
Working Groups
Stepping through in debug mode produces "Source Not Found" in Photon but not in Oxygen. If I take a small set of classes, create a Java Project, and then put those classes in the SRC directory, under Oxygen without any special configuration I can step through the execution just fine in debugging mode, but get the "source not found" error in Photon even if I'm only stepping through those exact same classes. What I tried in Photon - adding the source of the project manually to Photon (after clicking the button you get when source isn't found). this didn't work but the project's own source is already part of the source path (under default) checking the checkbox for the JRE. JRE: 1.8.0_181-b13 OS: Windows 7 x64, Windows 10 x64 Note that this happens EVEN if I'm only stepping from one user class to another - I'm not trying to step into libraries or JRE.
Please provide detailed steps to reproduce.
Created attachment 275288 [details] Zip File of Project How to Reproduce 1. Create project in Eclipse using 1.8 jre 2. copy this source into that eclipse project 3. Put debugging breakpoint at 2nd line in main (where it calls test method) 4. Run in debugging and try to step into that step (throws error in picture - see scratchpad png) Works fine in Eclipse Oxygen without ANY special configuration. I can replicate this with a fresh install of Eclipse Photon on either a Windows 7 or Windows 10 machine.
(In reply to Gary Furash from comment #2) > Created attachment 275288 [details] > Zip File of Project > > How to Reproduce > 1. Create project in Eclipse using 1.8 jre > 2. copy this source into that eclipse project > 3. Put debugging breakpoint at 2nd line in main (where it calls test method) > 4. Run in debugging and try to step into that step > (throws error in picture - see scratchpad png) Thanks for example, but I can't reproduce errors :-( > Works fine in Eclipse Oxygen without ANY special configuration. For me, using 4.9 HEAD works fine. Can you please check your example with http://download.eclipse.org/eclipse/downloads/drops4/I20180806-0300/? > I can replicate this with a fresh install of Eclipse Photon on either a > Windows 7 or Windows 10 machine. Most likely some exception is thrown in "PreMain": do you have errors either in the debug console or in the log? Can you please try to disable "Java->Debug->Use advanced source lookup"?
Is there anything else I can try? It really happens on either a win7 or win 10 machine with a FRESH install of the standard (java developer) eclipse photon using the standard jre. Is there a stack trace or something I could send you? How do I do that? Thanks!
If I turn off "Java->Debug->Use advanced source lookup"? it works perfectly with the default eclipse photon If i use the new built you sent the link to, it doesn't work unless i uncheck "Java->Debug->Use advanced source lookup"? So should I just leave that off? Thanks!
@Igor, Can you help here ?
Ping!!!
I'll try to find time to look at this either the next week or the week after.
I can't reproduce the problem using provided example project. Tried both 4.9M2 and 4.8. I am on OSX, so the problem could be Windows-specific. Also, Premain:53 (as per sceenshot) is a trivial == check [1]. Can't think of anything in jdt code that could trigger an exception there. [1] https://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/tree/org.eclipse.jdt.launching.javaagent/src/main/java/org/eclipse/jdt/launching/internal/javaagent/Premain.java?h=R4_8#n53
In the master line no 53 is inst.addTransformer(new ClassFileTransformer() {
I have the same problem on a "Linux 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux" with Eclipse photon 4.8.0 (Build id: 20180619-1200) the solution from Gary Furash to turn off "Java->Debug->Use advanced source lookup" works for me.
Created attachment 276668 [details] SourceNotFound I was able to reproduce this with 4.10 M3 build. Stepping into the creation of ClassA() or ClassB() gives this error as it reaches Premain$1.transform(ClassLoader, String, Class<?>, ProtectionDomain, byte[]) line: 45 Igor, we should fix this for 4.11.
@Sarika, not sure if you see the same behaviour as the original reporter, but in your case this is almost certainly normal step-into behaviour. When JVM loads a user class for the first time, it goes through bunch of non-user code, including sourcelookup agent instrumentation logic. Debugger stops in the agent code, if the agent code isn't explicitly "filtered" in debug preferences. The solution is to add agent package to the default set of step filters and possibly enable it by default. As a side note, sourcelookup agent isn't the only missing step filter. I _always_ add filters for java.lang.ClassLoader and couple of jdk.internal.* packages. So maybe we should review default set of filters and adjust them to provide better debugging experience.
New Gerrit change created: https://git.eclipse.org/r/132969
Gerrit change https://git.eclipse.org/r/132969 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=dbec8b943b1c75502353afd6dddc0081178771a4
@Gary, Can you confirm if you are still seeing/not seeing the problem?
@Sarika I had the problem, but I'm now on Eclipse 20190314-1200 with "Java->Debug->Use advanced source lookup" activated and everything works fine.
Marking as resolved in that case. Thanks!
