Bug 537434 - [syntax highlighting] Improve light theme - e.g. use dedicated default color (e.g. gray) for type arguments
Summary: [syntax highlighting] Improve light theme - e.g. use dedicated default color ...
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.9   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2018-07-27 03:53 EDT by Albert Tregnaghi CLA
Modified: 2018-08-06 09:48 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot showing up a possible default color for type parameters (2.78 KB, image/png)
2018-07-27 03:54 EDT, Albert Tregnaghi CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Tregnaghi CLA 2018-07-27 03:53:16 EDT
The dark theme is used by many developers and its ongoing and making much progress. But... I (and many others) are using still the light theme and there could be also some improvements.

So this issue could generally improve some initial settings of light or classic theme in eclipse to make it look a little bit modern by just setting some default non intrusive colors.

1. Color for type arguments
===========================
The first one: Dark theme uses dedicated colors to show up generic type information. Normally I am no fan of having too much colors around (dark theme coloring is sometimes a little bit too much...) but for generics this is more readable.

I defined following:
Preferences->Java->Editor->Syntax coloring:
Elements->Java->Type arguments:
 - enabled: true
 - Color: dark gray.

The result is in next attachment.
I find it much more readable than the default (uses just default text color which is black...) and not too intrusive.
Comment 1 Albert Tregnaghi CLA 2018-07-27 03:54:22 EDT
Created attachment 275152 [details]
Screenshot showing up a possible default color for type parameters
Comment 2 Dani Megert CLA 2018-08-06 09:48:17 EDT
This really boils down to personal taste.

Out of the box we color the type arguments like we color classes. They are also highlighted together when using Mark Occurrences.

The Dark theme has chosen otherwise, but I do not want to change this for the default/light theme.