Bug 537362 - Change ViewGenerator to create tables for containment references
Summary: Change ViewGenerator to create tables for containment references
Status: RESOLVED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.20.0   Edit
Assignee: Lucas Koehler CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy, test
Depends on:
Blocks:
 
Reported: 2018-07-25 04:18 EDT by Eugen Neufeld CLA
Modified: 2018-12-13 03:04 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugen Neufeld CLA 2018-07-25 04:18:36 EDT
Current Behavior:
The emfforms view model generator currently only creates controls for all features. This results in a MultiReferenceControl for containment and non containment references.

Expected behavior:
The more common requirement is to have a table for containment references as the user usually wants to directly edit attributes of contained objects.

Implementation and possible regressions
This will result in a dependencies of the view model generator to the table bundles. Also existing users which rely on the generator will have a different control and will need to create a dedicated view model to keep the old behavior.
Comment 1 Eugen Neufeld CLA 2018-08-22 09:35:52 EDT
Mass Move due to time constraints
Comment 2 Eugen Neufeld CLA 2018-11-06 04:41:01 EST
Mass move to 1.20 due to time constraints.
Comment 3 Eclipse Genie CLA 2018-12-12 10:30:06 EST
New Gerrit change created: https://git.eclipse.org/r/133935
Comment 5 Lucas Koehler CLA 2018-12-13 03:04:17 EST
The view generator now generates table controls for multi containment references. As a consequence, by default an editable table is shown for multi containment references. Until now a simple list was shown. For all other cases the generation stays the same.

TEST INFORMATION
Summary of the critical part of the change
The view generator now generates table controls instead of normal controls for multi containment references.

Potential regressions
If generated views with multi containment references are used, the view changes. The contained objects are now directly editable in the table. The table has a column for every attribute of contained objects.

Affected areas / use cases
Using auto generated views for EObjects that have multi containment references.

Things that shall be tested
That generated views still look as expected.