Bug 537141 - [CSS] Papyrus should rewire its dependencies to the CSSXMLEngineImpl and related classes
Summary: [CSS] Papyrus should rewire its dependencies to the CSSXMLEngineImpl and rela...
Status: NEW
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 4.2.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 6.0.0   Edit
Assignee: Quentin Le Menez CLA
QA Contact:
URL:
Whiteboard: Confirmed
Keywords: api
Depends on:
Blocks:
 
Reported: 2018-07-18 06:04 EDT by Quentin Le Menez CLA
Modified: 2020-12-10 08:40 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Le Menez CLA 2018-07-18 06:04:57 EDT 
These classes have been deleted from the eclipse patform UI repository.
Comment 1 Quentin Le Menez CLA 2018-07-18 06:05:34 EDT 
see Bug 534764 for more information.
Comment 2 Eclipse Genie CLA 2018-07-18 06:09:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/126233
Comment 4 Camille Letavernier CLA 2018-07-23 08:58:32 EDT 
Hi,

Did you try with a simple CSSEngineImpl? It might avoid the whole XML duplication (Which we probably don't use anyway).

It might be hard to test though, since (I believe) we don't have any CSS-SVG customization in Papyrus
Comment 5 Quentin Le Menez CLA 2018-07-24 04:07:55 EDT 
Indeed I did not find any uses of that specific implementation in Papyrus. All we have/provide is an extension point but we do not seem to consume it ourselves (though I admit I still have to parse all of our repositories).
The duplication was mainly because of the M1 getting close and I did not have enough time to see what could go wrong by removing this.
If I can I do think the simple CSSEngineImpl should be enough for us though and would remove the need of this patch.
Comment 6 Quentin Le Menez CLA 2020-12-10 08:40:46 EST 
This completly got out of sight for this release. Postponed to the next one.