Bug 537092 - Passwords do not match
Summary: Passwords do not match
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Accounts.eclipse.org (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Eric Poirier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 540088 545915 546919 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-07-17 01:14 EDT by Yuan-Liang Tang CLA
Modified: 2020-12-22 14:15 EST (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuan-Liang Tang CLA 2018-07-17 01:14:00 EDT
I am trying to "Edit my profile" here (https://accounts.eclipse.org/users/ytang6oj/edit), but the system keeps complaining with the message: "The specified passwords do not match" even if my password is correct.
Comment 1 Denis Roy CLA 2018-09-26 10:40:43 EDT
I believe this is caused by the browser prepopulating the first password field in the Change Password section on the Account Settings tab.

Since that tab is not shown, it's not clear to the user which passwords do not match.
Comment 2 Christopher Guindon CLA 2018-09-26 10:44:56 EDT
(In reply to Denis Roy from comment #1)
> I believe this is caused by the browser prepopulating the first password
> field in the Change Password section on the Account Settings tab.
> 
> Since that tab is not shown, it's not clear to the user which passwords do
> not match.

Correct!

I found this helpful article on the subject:
https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion

"In some cases, the browser will continue suggesting autocompletion values even if the autocomplete attribute is set to off. This unexpected behavior can be quite puzzling for developers. The trick to really enforcing non-autocompletion is to assign an invalid value to the attribute, for example:
autocomplete=“nope”"

We can try adding an invalid value to the autocomplete attribute. The problem here is that behavior might not apply to all browsers or could change in a future update.


An alternative would be the jQuery disableAutoFill Plugin:
https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion
Comment 3 Christopher Guindon CLA 2018-09-27 10:38:28 EDT
I created a first patch for this:
https://foundation.eclipse.org/r/2851

This patch will add an invalid value to the password field as suggested in:
https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion

I will try to deploy this today on production. I will update the bug once it's there! I will need the help of the community to test this since I am unable to reproduce this usability issue.

This issue might take a few tries before we get it right.
Comment 4 Christopher Guindon CLA 2018-09-28 09:47:47 EDT
Our patch is now on production.

Can someone verify if this made a difference?
Comment 5 Yuan-Liang Tang CLA 2018-09-28 11:11:11 EDT
Tested. The bug is fixed. Great job.
Comment 6 Christopher Guindon CLA 2018-09-28 11:12:08 EDT
(In reply to Sugar Tang from comment #5)
> Tested. The bug is fixed. Great job.

Great!
Thanks for helping us fix this issue!
Comment 7 James Krueger CLA 2018-10-02 11:31:32 EDT
Either this bug has not been fixed, or the change has not be publicly distributed.  
Any attempt I make to change anything in my profile fails with the "The specified passwords do not match.".  https://accounts.eclipse.org/users/jkruegerip3
Comment 8 Christopher Guindon CLA 2018-10-02 11:33:32 EDT
(In reply to James Krueger from comment #7)
> Either this bug has not been fixed, or the change has not be publicly
> distributed.  
> Any attempt I make to change anything in my profile fails with the "The
> specified passwords do not match.". 
> https://accounts.eclipse.org/users/jkruegerip3

What browser are you using?
Comment 9 James Krueger CLA 2018-10-02 15:02:20 EDT
Firefox 60.2.1esr on Windows 7.

This problem is also being seen by ed.bratt@oracle.com
Comment 10 Christopher Guindon CLA 2018-10-02 16:43:18 EDT
(In reply to James Krueger from comment #9)
> Firefox 60.2.1esr on Windows 7.
> 
> This problem is also being seen by ed.bratt@oracle.com

Some users are suggesting that we use:

autocomplete="new-password"

I will try to use autocomplete="new-password". If that does not work, we will need to consider changing how/where we load the new password fields.

https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands
Comment 11 Christopher Guindon CLA 2018-10-05 16:49:44 EDT
(In reply to Christopher Guindon from comment #10)
> (In reply to James Krueger from comment #9)
> > Firefox 60.2.1esr on Windows 7.
> > 
> > This problem is also being seen by ed.bratt@oracle.com
> 
> Some users are suggesting that we use:
> 
> autocomplete="new-password"
> 
> I will try to use autocomplete="new-password". If that does not work, we
> will need to consider changing how/where we load the new password fields.
> 
> https://www.chromium.org/developers/design-documents/form-styles-that-
> chromium-understands

(In reply to James Krueger from comment #9)
> Firefox 60.2.1esr on Windows 7.
> 
> This problem is also being seen by ed.bratt@oracle.com

We are now using autocomplete="new-password". 

Could you confirm if you see a difference with Firefox?
Comment 12 Christopher Guindon CLA 2018-10-12 14:00:12 EDT
*** Bug 540088 has been marked as a duplicate of this bug. ***
Comment 13 Ed Bratt CLA 2018-10-12 15:01:13 EDT
After reading this, I opened the account settings and cleared the 'change your password' field -- then was able to upload my avatar. Whatever causes this to happen is still broken, but the workaround here did solve the problem.
Comment 14 Christopher Guindon CLA 2018-10-12 15:20:37 EDT
(In reply to Ed Bratt from comment #13)
> After reading this, I opened the account settings and cleared the 'change
> your password' field -- then was able to upload my avatar. Whatever causes
> this to happen is still broken, but the workaround here did solve the
> problem.

Hi Ed,

Could you let us know what browser and the version that you are using?
Comment 15 Ed Bratt CLA 2018-10-12 15:38:31 EDT
Firefox Quantum (ESR). 60.2.2esr
Comment 16 Yuan-Liang Tang CLA 2019-01-21 22:00:12 EST
There problem still remains. I tried to upload a new photo here (https://accounts.eclipse.org/users/<username>/edit). The system keeps complaining about "The specified passwords do not match."
Comment 17 Christopher Guindon CLA 2019-03-29 08:17:08 EDT
*** Bug 545915 has been marked as a duplicate of this bug. ***
Comment 18 Christopher Guindon CLA 2019-04-08 14:25:05 EDT
(In reply to Christopher Guindon from comment #17)
> *** Bug 545915 has been marked as a duplicate of this bug. ***

We tried a few things last week but none of them were successful. 

We now think that the only way to solve this would be to move the "change my password" feature on a separate page.
Comment 19 Eric Poirier CLA 2019-05-02 09:51:03 EDT
*** Bug 546919 has been marked as a duplicate of this bug. ***
Comment 20 Christopher Guindon CLA 2019-05-02 09:52:51 EDT
I am upping the priority since this is something that we should fix soon!
Comment 21 Eric Poirier CLA 2020-12-22 14:15:33 EST
We have recently add an autocomplete="new-password" attribute to the new password fields.

I believe the password do not match issue has been fixed because of this update.

Please reopen this bug if there's still an issue with the password fields.

Thanks.