Community
Participate
Working Groups
Example #1: public <T> EntityReader<T, Path> createEntityReader( Class<T> entity, Path path, CoreCSVSettings settings, Function<? super String, ? extends String> colNameMapper, Function<? super String[], ? extends T> instantiator, Map<String, ?> runtimeValues, LoadValueConverter converter) throws IOException { /* * Eclipse's error: * * The method createEntityStreamReader(Class<T>, Callable<InputStream>, CoreCSVSettings, Function<? super String,? extends String>, Function<? super String[],? extends T>, Map<String,?>, LoadValueConverter) * in the type FilePersisterFactoryImpl is not applicable for the arguments * (Class<T>, Callable<InputStream>, CoreCSVSettings, Function<capture#9-of ? super String,capture#10-of ? extends String>, Function<capture#11-of ? super String[],capture#12-of ? extends T>, Map<String,capture#13-of ?>, LoadValueConverter) */ EntityReader<T, ?> streamReader = createEntityStreamReader(entity, ExtraIOUtils.getInputStreamProvider(path), // returns a Callable<InputStream> settings, colNameMapper, instantiator, runtimeValues, converter); ... } public <T> EntityReader<T, Callable<InputStream>> createEntityStreamReader( Class<T> entity, Callable<InputStream> streamProvider, CoreCSVSettings settings, Function<? super String, ? extends String> colNameMapper, Function<? super String[], ? extends T> instantiator, Map<String, ?> runtimeValues, LoadValueConverter converter) throws IOException { ... whatever ... } ------------------------------------------------------------ Example #2: public <T> EntityReader<T, Callable<InputStream>> createEntityStreamReader( Class<T> entity, Callable<InputStream> streamProvider, CoreCSVSettings settings, Function<? super String, ? extends String> colNameMapper, Function<? super String[], ? extends T> instantiator, Map<String, ?> runtimeValues, LoadValueConverter converter) throws IOException { /* * Eclipse's error: * * The method resolveInstantiator(Class<T>, Function<? super String[],? extends T>) * in the type FilePersisterFactoryImpl is not applicable for the arguments * (Class<T>, Function<capture#29-of ? super String[],capture#30-of ? extends T>) */ Function<? super String[], ? extends T> factory = resolveInstantiator(entity, instantiator); .... } protected <T> Function<? super String[], ? extends T> resolveInstantiator( Class<T> entity, Function<? super String[], ? extends T> instantiator) { .... whatever .... } -------------------------------------------------------- * I am using OpenJDK Java 8 build 172 running on Fedora 27 * The code compiles just fine outside of Eclipse via the Java compiler * Eclipse Oxygen (!) has no problems with this code...
I marked it as "Critical" since it is a regression problem which makes using Eclipse Photon on existing code problematic to say the least. For now, I worked around it by using raw class casts since (for now...) it occurs only in these 2 locations and I can live with it for the time being. However, this is not likely to hold for long and we are likely to encounter code that we cannot (or do not want) to "spoil" by such un-necessary casts...
I briefly tried to reproduce, but there's way too much stuff missing from the code in comment 0 for me to be able to guess. Please provide sufficient stubs for all types and methods involved.
Here is the necessary stubbing which should suffix (IMO) to reproduce - as can be plainly seen they are all interfaces - I have listed all of them - including the non-generic ones public interface CoreCSVSettings { /** * Default charset if none specified */ Charset DEFAULT_CHARSET = Charset.forName(DEFAULT_CODE_PAGE); String getCodePage(); /** * Default delimiter if none specified */ Character DEFAULT_DELIMITER = ','; Character getColumnDelimiter(); /** * Default assumption about the first row being headers or not */ Boolean DEFAULT_HEADER_ROW = Boolean.TRUE; Boolean getFirstRowIsHeader(); } -------------------------------------------------------- /** * Used to convert values read from CSV into ones compatible with the * expected database column type */ public interface LoadValueConverter { /** * @param pathIndicator The file path indicator from which the value originates. * <B>Note:</B> the actual type depends on the implementation, it is highly * recommended though that the {@code toString()} method yield a useful path value * @param lineNumber <P>The line number from which this column value was read.<B>Note(s):</B></BR> * <UL> * <LI> * The line numbers start at <B>1</B> - i.e., 1, 2, 3 * </LI> * * <LI> * The line numbers refer to <U>data</U> lines - i.e., if the CSV file * has a header line it is not counted and the "first" line * is still reported as {@code 1} even though it is physically the 2nd one. * </LI> * </UL> * @param tableName The table name into which the data is being loaded * @param colName The <U>mapped</U> column name - as it appears in the database * @param colType The column type * @param value The read value * @return The equivalent database object to use */ Object convert(Object pathIndicator, long lineNumber, String tableName, String colName, Class<?> colType, String value); } ---------------------------------------------------------------------------- /** * @param <T> Type of entity being managed */ public interface EntityIndicator<T> { Class<T> getEntity(); } ---------------------------------------------------------------------------- /** * @param <S> Persistence storage type - e.g., file, database, etc. */ public interface PersisterStorage<S> extends java.nio.channels.Channel { /** * @return Type of backing storage for the persister - file, database, etc. */ Class<S> getStorageType(); /** * @return The persisted storage instance that is actually used - file, database, etc. */ S getStorageInstance(); /** * @return A <U>snapshot</U> of the original settings used to instantiate this object */ CoreCSVSettings getSettings(); /** * @return The current read/write number <U>excluding</U> the headers line (if any) */ int getCurrentLineNumber(); } ---------------------------------------------------------------------------- /** * Represents a read or write entity persister resources * * @param <T> Type of entity being persisted * @param <S> Persistence storage type - e.g., file, database, etc. */ public interface EntityPersister<T, S> extends EntityIndicator<T>, PersisterStorage<S> { Callable<T> getEntityDescriptor(); } ---------------------------------------------------------------------------- /** * Represents a persister resource for reading entities from the persistence storage * * @param <T> Type of entity being persisted * @param <S> Persistence storage type - e.g., file, database, etc. */ public interface EntityReader<T, S> extends EntityPersister<T, S> { /** * Reads an instance from the persistence storage * * @return The read instance - {@code null} if EOF reached * @throws IOException If reflection API related issues encountered */ T read() throws IOException; /** * Reads all remaining instances * * @return A {@link Collection} of the read values until EOF is reached * @throws IOException If reflection API related issues encountered */ default Collection<T> readAll() throws IOException { Collection<T> values = new LinkedList<>(); for (T v = read(); v != null; v = read()) { values.add(v); } return values; } } ----------------------------------------------------------------------------
As far as providing stubs for the methods - it is irrelevant - you can simply do "return null" - the problem is that they don't compile...
Any progress on this issue ? If there is any more information missing please let me know...
I see the error "The method createEntityStreamReader(Class<T>, Callable<InputStream>, CoreCSVSettings, Function<? super String,? extends String>, Function<? super String[],? extends T>, Map<String,?>, LoadValueConverter) in the type Snippet is not applicable for the arguments (Class<T>, Callable<InputStream>, CoreCSVSettings, Function<capture#1-of ? super String,capture#2-of ? extends String>, Function<capture#3-of ? super String[],capture#4-of ? extends T>, Map<String,capture#5-of ?>, LoadValueConverter)" Is this what you see too? And I can confirm Javac doesn't report any error.
Yes, this is exactly the one - see also the initial comment on the issue where this exact error is recorded on this example and also another.
The same error can be reproduced with this code (requires guava 18.0 on the classpath) : example #1 (error): public final class Entity implements Comparable { private int index = 1; public Entity(int index) { this.index = index; } public int compareTo(Object o) { return index; } } import com.google.common.collect.Range; public class Test { public static void main(String[] args) { Entity d1 = new Entity(1); Entity d2 = new Entity(2); Range<Entity> r = Range.closed(d1, d2); } } This only happens if you don't specify an argument type for the Comparable generic interface in the Entity class. example #2 (no error): public final class Entity implements Comparable<Entity> { private int index = 1; public Entity(int index) { this.index = index; } public int compareTo(Entity o) { return index; } } import com.google.common.collect.Range; public class Test { public static void main(String[] args) { Entity d1 = new Entity(1); Entity d2 = new Entity(2); Range<Entity> r = Range.closed(d1, d2); } } Interestingly if you declare the Entity class as a static inner class within the main class where it's used, then the error disappears ! example #3 (no error) public class Test { public static void main(String[] args) { Entity d1 = new Entity(1); Entity d2 = new Entity(2); Range<Entity> r = Range.closed(d1, d2); } public static final class Entity implements Comparable { private int index = 1; public Entity(int index) { this.index = index; } public int compareTo(Object o) { return index; } } }
Any progress on this issue ? We have dozens of similar errors in our enterprise application when upgarding to Photon. It means a no-go for us because the non-generic Comparable interface comes from an external library (joda-time 1.6.2) and we cannot afford to upgrade now. Thank you !
(In reply to Thomas Naskali from comment #9) > Any progress on this issue ? We have dozens of similar errors in our > enterprise application when upgarding to Photon. It means a no-go for us > because the non-generic Comparable interface comes from an external library > (joda-time 1.6.2) and we cannot afford to upgrade now. Thank you ! Your issue seems to be caused by mixture of raw types and generics, but the issue from comment#0 not, so please create a separate bug.
Thank you for the answer, I just opened bug#540208.
FYI still occurs in Eclipse 2018-12. As a veteran supporter of Eclipse and what it represents I would like to mention that IntelliJ IDEA does not have this problem and many of my R&D team members are simply ditching Eclipse because of this type of continued issues (and sadly, I am inclined to follow). Not only due to this issue, but quite a few others related to the fact that perfectly good code needs to be "twisted" just to be able to use it in Eclipse - e.g., 537593, 544757. Not only that, but with each new Eclipse release it seems that more bugs of this type are popping up.
New Gerrit change created: https://git.eclipse.org/r/137578
It still took me a while to reproduce the error, but finally I succeeded to get a self-contained 30-something-lines example. [1] NB for future bug reports: if not possible to produce a complete single file example (please incl. imports) it's best to attach a configured zip Eclipse project. This greatly reduces risk of a report falling between the cracks. Once I had the test case it was quite straight-forward, to locate where ecj fails to recognize that String[] <: capture-of ? String[] should evaluate to TRUE. Strictly speaking this is not a regression, the faulty method has been like this since bug 428019 (5 years ago). It is still possible, that some other fix between then and now increased the chance of hitting this bug. I'm scheduling this for 4.12 since 4.11 is already cooling down. Still, if s.o. from the team supports the fix it should be ready, if jenkins approves. The fix is simply done by "borrowing" a corresponding paragraph from method isCompatibleWith(). [1] https://git.eclipse.org/r/#/c/137578/1/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/GenericsRegressionTest_1_8.java
(In reply to Stephan Herrmann from comment #14) > ... if jenkins approves ... Jenkins gave +1
*** Bug 544757 has been marked as a duplicate of this bug. ***
(In reply to Stephan Herrmann from comment #14) > I'm scheduling this for 4.12 since 4.11 is already cooling down. > > Still, if s.o. from the team supports the fix it should be ready, if jenkins > approves. +1 review +1 for 4.11 as well
Gerrit change https://git.eclipse.org/r/137578 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=51935ee9d486419f4f1f74060e0b14409482d023
(In reply to Eclipse Genie from comment #18) > Gerrit change https://git.eclipse.org/r/137578 was merged to [master]. > Commit: > http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/ > ?id=51935ee9d486419f4f1f74060e0b14409482d023 Thanks Stephan - rebased and committed for RC1
(In reply to Manoj Palat from comment #19) > (In reply to Eclipse Genie from comment #18) > > Gerrit change https://git.eclipse.org/r/137578 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/ > > ?id=51935ee9d486419f4f1f74060e0b14409482d023 > > Thanks Stephan - rebased and committed for RC1 Thanks Manoj
Verified for 4.11 RC1 using build I20190227-1800
*** Bug 538126 has been marked as a duplicate of this bug. ***
