Community
Participate
Working Groups
I have no idea how hard is it for jdt.junit to join the band wagon of bug 41353? Would solving this in jdt.junit first also help PDE, or would that be independent?
>>Would solving this in jdt.junit first also help PDE, or would that be >>independent? I think a separate change is PDE will also be required just like launch config issue. Axel, do you have any plans for this one for 4.9 or 4.10 ?
Hello, Please take a look at https://www.eclipse.org/eclipse/news/4.8/platform_isv.php#prototype-launch-configuration to see how to support launch configuration prototypes for JUnit. You can also take a look at existing supports (Java & PDE): -http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/tree/org.eclipse.jdt.launching/plugin.xml -http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/tree/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/debug/ui/launchConfigurations/JavaArgumentsTab.java -https://git.eclipse.org/c/pde/eclipse.pde.ui.git/tree/ui/org.eclipse.pde.launching/plugin.xml - https://git.eclipse.org/c/pde/eclipse.pde.ui.git/tree/ui/org.eclipse.pde.ui/src/org/eclipse/pde/ui/launcher/ConfigurationTab.java These examples will definitely help you to implement the support for JUnit. Best regards,
New Gerrit change created: https://git.eclipse.org/r/157800
I started a patch about prototype for JUnit run / debug configurations. It's a WIP patch as I think there is more to do. I need some information about which labels to use for JUnit configuration attributes. * org.eclipse.jdt.junit.CONTAINER * org.eclipse.jdt.junit.KEEPRUNNING_ATTR * org.eclipse.jdt.junit.TESTNAME * org.eclipse.jdt.junit.TEST_KIND See the following screen shot for more informations.
Created attachment 281835 [details] screenshot of prototype tab for JUnit prototype
Did someone have time to see this first version of run configuration prototype? I don't know who is in charge of JUnit support so I didn't add a reviewer.
I will look at it for 4.16.
Also, requesting Roland to provide initial feedback.
Thanks Noopur. If I create other JUnit patches, should I add you as a reviewer?
(In reply to Gautier de SAINT MARTIN LACAZE from comment #4) > I started a patch about prototype for JUnit run / debug configurations. It's > a WIP patch as I think there is more to do. > > I need some information about which labels to use for JUnit configuration > attributes. From some research, here's a rough idea. > * org.eclipse.jdt.junit.CONTAINER "The Java element handle ID (if any)" (See ./org.eclipse.jdt.junit/src/org/eclipse/jdt/junit/launcher/JUnitLaunchConfigurationTab.java performApply() ) > * org.eclipse.jdt.junit.KEEPRUNNING_ATTR "Keep JUnit running after test run when debugging" (See org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/JUnitMessages.properties) > * org.eclipse.jdt.junit.TESTNAME "Test method name (if any)" (See ./org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/launcher/JUnitLaunchConfigurationConstants.java ATTR_TEST_NAME) > * org.eclipse.jdt.junit.TEST_KIND "Unique ID for JUnit test kind" (See org.eclipse.jdt.junit.core/src/org/eclipse/jdt/internal/junit/launcher/TestKindRegistry.java) I would think this value can only be : org.eclipse.jdt.junit.loader.junit[3-5]
Hello Roland, Thanks for your comment. I uploaded a new patch set on gerrit. I reused the label for `org.eclipse.jdt.junit.KEEPRUNNING_ATTR` and use `LegacyActionTools.removeMnemonics` to remove the mnemonic. Should I duplicate the value in another string without mnemonic?
(In reply to Gautier de SAINT MARTIN LACAZE from comment #11) > Hello Roland, > > Thanks for your comment. > > I uploaded a new patch set on gerrit. I reused the label for > `org.eclipse.jdt.junit.KEEPRUNNING_ATTR` and use > `LegacyActionTools.removeMnemonics` to remove the mnemonic. Should I > duplicate the value in another string without mnemonic? The reason I didn't mention using existing labels directly is because I thought some of the explanations were more "descriptions" in that they're pretty long, and a few words could be removed here and there to shorten them. With that said, after trying the Prototype Tab, it doesn't seem as bad as I thought, so if you're fine with the labels for the attributes, then that's fine.
Sorry, I was busy on another project. I'm fine with current labels.
This enhancement would be a big win for me and other people on the team I work with. What are the prospects of the patch that's attached to this bug being pushed through to completion and delivery?
I would like this too!
This feature would really help our team! please prioritize when possible :) Thanks!
@Gautier, Can you explain the reason what will be the scenario where people will want to create common prototype for same Test Method Name or Java Element Handle ID?
As bugzilla is dead, I've opened https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1333 and I'm closing this one.
