Bug 536466 - Update of the color palette at runtime
Summary: Update of the color palette at runtime
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 6.0.0   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-06-29 05:59 EDT by Frédéric Madiot CLA
Modified: 2018-07-11 05:34 EDT (History)
3 users (show)

See Also:


Attachments
Sample VSM (5.69 KB, application/x-zip-compressed)
2018-07-02 04:46 EDT, Frédéric Madiot CLA
no flags Details
screenshot (7.78 KB, image/png)
2018-07-02 04:47 EDT, Frédéric Madiot CLA
no flags Details
screenshot (7.24 KB, image/png)
2018-07-02 04:50 EDT, Frédéric Madiot CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Madiot CLA 2018-06-29 05:59:32 EDT
The color changes in the in User Color Palette are not reflected at runtime in the Properties View (Appearance tab).
Comment 1 Frédéric Madiot CLA 2018-07-02 04:46:26 EDT
Created attachment 274734 [details]
Sample VSM

This VSM defines a viewpoint "Color Test" on Ecore.
It defines three colors : Color1, Color2 and Color3.
When applied, you can see that the order of these three colors in the palette seems has no relation with the order in the VSM. 

In addition, the colors of this VSM are mixed with those defined by Ecore Tools.
Comment 2 Frédéric Madiot CLA 2018-07-02 04:47:51 EDT
Created attachment 274735 [details]
screenshot
Comment 3 Frédéric Madiot CLA 2018-07-02 04:50:41 EDT
Created attachment 274736 [details]
screenshot

On this screenshot you can see how Color1, Color2 and Color3 are placed in the palette
Comment 4 Eclipse Genie CLA 2018-07-02 05:42:42 EDT
New Gerrit change created: https://git.eclipse.org/r/125323
Comment 5 Laurent Fasani CLA 2018-07-02 05:48:10 EDT
I've just pushed the commit in gerrit https://git.eclipse.org/r/125323 in blind mode. It probably fixes the issue but I did not test it.
Automatic test has to be added too.
Comment 6 Pierre-Charles David CLA 2018-07-11 04:57:59 EDT
(In reply to Frederic Madiot from comment #0)
> The color changes in the in User Color Palette are not reflected at runtime
> in the Properties View (Appearance tab).

I'm not sure I understand this ticket. The title and this comment seems to say that changes in the color definition inside the VSM are not correctly taken into account, but the rest of the comments and the screenshot seem to be about another issue related to the order of the elements of the palette not corresponding to the order they are defined in the VSM.

Are there two separate issues? If not, which one is this about?
Comment 7 Pierre-Charles David CLA 2018-07-11 05:34:47 EDT
It seems there are indeed two issues:
* this one is about the fact that changes in the VSM are not taken into account in the appearance tab's UI;
* the other (and the patch) is about the inconsistent ordering, but the comments here about this second issue where probably meant for https://bugs.eclipse.org/bugs/show_bug.cgi?id=536465 which is about the ordering problem.