Bug 536246 - View Templates should allow to register more than one template
Summary: View Templates should allow to register more than one template
Status: RESOLVED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.18.0   Edit
Assignee: Lucas Koehler CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2018-06-25 08:27 EDT by Eugen Neufeld CLA
Modified: 2018-07-10 06:35 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugen Neufeld CLA 2018-06-25 08:27:26 EDT 
The ViewTemplates should be refactored to be osgi service based instead of relying on the implementation.
Furthermore the xmi template provider should be changed to support more than one file being registered at once.
Comment 1 Eclipse Genie CLA 2018-07-05 12:30:07 EDT 
New Gerrit change created: https://git.eclipse.org/r/125651
Comment 2 Lucas Koehler CLA 2018-07-10 05:13:37 EDT 
TEST INFORMATION

Summary of the critical part of the change
The ViewTemplateSupplier can now process multiple view templates that are supplied by instances of the newly defined ViewTemplateSupplier. The ViewTemplateSupplierImpl now reads in the same extension point as the old ViewTemplateProviderImpl. Thereby, it can also read in multiple view models.
In case there is more than one view template, ViewTemplateProviderImpl.getViewTemplate returns a "merged" view template of all supplied view templates. Thereby, only one control validation template can be used.

Potential regressions
The ViewModelProvider.getViewTemplate and .hasControlValidationTemplate methods are now deprecated. This can lead to additional warnings in custom implementations.

Affected areas / use cases
Styling of views with view templates.

Things that shall be tested
That existing view templates are still correctly applied.