Bug 5362 - Deeper than necessary JavaElementDelta when package added
Summary: Deeper than necessary JavaElementDelta when package added
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.0 M1   Edit
Assignee: Philipe Mulet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-30 12:02 EST by Jerome Lanneluc CLA
Modified: 2002-01-11 09:13 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2001-10-30 12:02:21 EST 
Build 206 - 20011025

1. Add the following packages and compilation unit:
    x
      A.java
    x.y
      B.java
2. You get a JavaElementDelta with the following structure
    x (ADDED)
      A.java (ADDED)
    x.y (ADDED)
      B.java (ADDED)

JavaElementDeltas on A.java and B.java are unnecessary.
Comment 1 Philipe Mulet CLA 2001-11-02 16:57:45 EST 
Need to investigate.

1. Did we spec these deltas to contain leaf added elements ?

2. Would we break current clients ?
Comment 2 Erich Gamma CLA 2001-11-05 09:43:24 EST 
The UI would not be affected.
However, the delta semantics of Resource and Java deltas should be the same.
Comment 3 Jerome Lanneluc CLA 2001-11-09 07:47:55 EST 
Fixed by processing children only if delta is changed.
Package fragments are processed separately as subpackages addition/deletion 
must also be reported.