Bug 536051 - IP validation only runs sporadically
Summary: IP validation only runs sporadically
Status: CLOSED DUPLICATE of bug 540694
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: GitHub (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-19 08:48 EDT by James Roper CLA
Modified: 2018-12-03 12:30 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Roper CLA 2018-06-19 08:48:56 EDT
In the MicroProfile Reactive project (https://github.com/eclipse/microprofile-reactive), we're seeing IP validation only running sporadically - there have been times where a PR should have failed validation, but we merged it because the validation didn't run and we didn't notice. We also use the Jenkins GitHub PR validation plugin, so it's easy to fail to notice that the IP validation hasn't run since the status will be green from the Jenkins validation. Here are some PRs where IP validation didn't run:

https://github.com/eclipse/microprofile-reactive/pull/36
https://github.com/eclipse/microprofile-reactive/pull/28

Here are some PRs showing both that IP validation and Jenkins ran for comparison:

https://github.com/eclipse/microprofile-reactive/pull/29
https://github.com/eclipse/microprofile-reactive/pull/37

The above PRs are all closed now, to see which validations ran you need to click on the tick next to the commit - in the case that both Jenkins and IP validation ran, it will pop up a little box showing you both validations with links to see their results, in the case that only Jenkins ran, clicking the tick will take you straight to Jenkins.

Empirically, I've noticed it only running about 50% of the time.
Comment 1 James Roper CLA 2018-07-11 00:53:34 EDT
Bump. It seems to be worse now, looking over pull requests from the past 2 weeks, IP validation only ran 20% of the time. Looking over other Eclipse projects in the Eclipse GitHub organization that have ip validation running on them, it seems that microprofile-reactive is not alone, it appears to be running sporadically on most other MicroProfile projects.
Comment 2 Denis Roy CLA 2018-12-03 12:30:32 EST

*** This bug has been marked as a duplicate of bug 540694 ***