Bug 536034 - Xtext builder runs during saving workspace state.
Summary: Xtext builder runs during saving workspace state.
Status: NEW
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-19 04:47 EDT by Ed Willink CLA
Modified: 2018-06-19 05:48 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2018-06-19 04:47:40 EDT 
Using the Photon RC2 Modeling EPP. After restarting a couple of times after a kill (See Bug 536032). I uninstalled EMF Compare and accepted the restart dialog. Takes a long time since Xtext is determined to build everything before allowing the save to complete. It's going to rebuild everything anyway after the restarts so why before as well?
Comment 1 Christian Dietrich CLA 2018-06-19 04:52:29 EDT 
i am not sure about that. (the rebuild anyway part - that might be caused by platform itself - workspace outdated/corrupt)

the build on save itself might caused by 
org.eclipse.xtext.builder.builderState.EMFBasedPersister.addSaveParticipant()
calling org.eclipse.xtext.resource.IResourceDescriptions.getAllResourceDescriptions()
which calls
org.eclipse.xtext.builder.builderState.AbstractBuilderState.ensureLoaded()

@Ed are you sure it is a build that is happening and not 
storage2UriMapper running?

do you have jstack stacktraces?
Comment 2 Christian Dietrich CLA 2018-06-19 04:59:15 EDT 
p.s: are you sure the build is not the one after the previous restart?
Comment 3 Ed Willink CLA 2018-06-19 05:48:05 EDT 
re #1 I was seeing the using build chunk x of y that too often requires a cup of coffeee.

re #2 I had to wait for the old rebuilds before you I could do anything useful. So yes I am sure, but even if it was the old builds, they should have been cancelled. Once Eclipse is-closing-down all current builds should abort automatically, all new builds should be skippd.