Community
Participate
Working Groups
Created attachment 274450 [details] Screenshot The extension point description is not styled in the dark theme. See screenshot.
Roland, can you have a look? I have the vague memory that you already worked on this.
This is caused by org.eclipse.jface.internal.text.html.HTMLPrinter.insertPageProlog(StringBuilder, int, URL) called from PointSelectionPage#setPointDescriptionText(String). The description text is actually rendered in a browser (if available, mainly for things like nicely rendering bullet lists). Unforunately the insertPageProlog sets the body background colour to white on all systems. Assuming the HTMLPrinter part isn't changing, perhaps a simple search/replace in this case is enough to fix the issue. I can push something, but it needs to be polished/improved.
New Gerrit change created: https://git.eclipse.org/r/124564
Btw: When you click on "Open extension point description" the displayed doc is also has light background in the dark theme. The HTML is rendered in SchemaTransformer. You could add background and foreground color rules to the CSS there to make that fit into the theme.
Created attachment 274544 [details] Extension Point Description This is a screenshot of patchset 6. There a various problems. 1.) Hyperlink color to dark (there is a color preference for hyperlink colors. See how HTMLPrinter uses this and replaces "placeholders" in the CSS. 2.) Some text still is black 3.) The dark red test is too dark So in general the contrast between background and text colors is too low at these places. Which makes the text hard to read. See how the JavaDoc Hover of JDT does this nicely.
(In reply to Matthias Becker from comment #5) > Created attachment 274544 [details] > Extension Point Description > > This is a screenshot of patchset 6. > There a various problems. > 1.) Hyperlink color to dark (there is a color preference for hyperlink > colors. See how HTMLPrinter uses this and replaces "placeholders" in the CSS. > 2.) Some text still is black > 3.) The dark red test is too dark > > So in general the contrast between background and text colors is too low at > these places. Which makes the text hard to read. See how the JavaDoc Hover > of JDT does this nicely. The reason it looks nice in JavaDoc View is because it uses its own boilerplate stylesheet (eg. eclipse.jdt.ui/org.eclipse.jdt.ui/JavadocViewStyleSheet.css) and has HTMLPrinter.insertPageProlog(...) which sets the placeholders in that style sheet. ShowDescriptionAction relies on SchemaTransformer. It might be possible to add some basic support for the kind of placeholder replacement (from HTMLPrinter) in SchemaTransformer but I'll also have to see how those 2 existing stylesheets (schema.css, book.css) influence an additional one.
(In reply to Roland Grunberg from comment #6) > The reason it looks nice in JavaDoc View is because it uses its own > boilerplate stylesheet (eg. > eclipse.jdt.ui/org.eclipse.jdt.ui/JavadocViewStyleSheet.css) and has > HTMLPrinter.insertPageProlog(...) which sets the placeholders in that style > sheet. ShowDescriptionAction relies on SchemaTransformer. > > It might be possible to add some basic support for the kind of placeholder > replacement (from HTMLPrinter) in SchemaTransformer but I'll also have to > see how those 2 existing stylesheets (schema.css, book.css) influence an > additional one. Are these 2 existing stylesheets also used in other places?
Should we move the schema styling to another bug? Seems like a separate topic to me.
(In reply to Lars Vogel from comment #8) > Should we move the schema styling to another bug? Seems like a separate > topic to me. Would be okay for me.
(In reply to Matthias Becker from comment #7) > (In reply to Roland Grunberg from comment #6) > > The reason it looks nice in JavaDoc View is because it uses its own > > boilerplate stylesheet (eg. > > eclipse.jdt.ui/org.eclipse.jdt.ui/JavadocViewStyleSheet.css) and has > > HTMLPrinter.insertPageProlog(...) which sets the placeholders in that style > > sheet. ShowDescriptionAction relies on SchemaTransformer. > > > > It might be possible to add some basic support for the kind of placeholder > > replacement (from HTMLPrinter) in SchemaTransformer but I'll also have to > > see how those 2 existing stylesheets (schema.css, book.css) influence an > > additional one. > Are these 2 existing stylesheets also used in other places? I would have thought so given that in general, the locations getting resolved originate from the product plugin (eg. org.eclipse.sdk), org.eclipse.platform, or org.eclipse.platform.doc.isv . However, grepping through the platform aggregator, it looks like book.css is only also used by the help system (org.eclipse.help.webapp), and schema.css only by PDE UI. (In reply to Matthias Becker from comment #9) > (In reply to Lars Vogel from comment #8) > > Should we move the schema styling to another bug? Seems like a separate > > topic to me. > > Would be okay for me. That would be great. It isn't entirely separate but it is a more general case. With the description text there's mainly just the plain text to render and maybe some lists to display. With the entire schema definition (eg. configuration markup, examples, etc.) the variety of content requires additional work.
(In reply to Roland Grunberg from comment #10) > > Would be okay for me. > > That would be great. Can you update your patch to only cover the extension point description?
Matthias, could you open a new bug for the schema color issue?
(In reply to Lars Vogel from comment #12) > Matthias, could you open a new bug for the schema color issue? done
Thanks, Roland
Gerrit change https://git.eclipse.org/r/124564 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1570858e618065507539ebea4cd4d776f9307d9e
Can anyone (working on dark theme) verify this one?
verified in I20180731
Roland/Mathias, can you please add a N&N entry for this one?
Can someone add N&N item for this ?
(In reply to Vikas Chandra from comment #19) > Can someone add N&N item for this ? Sorry for the delay. If no one is taking this I'll be sure to add something before the week is up.
New Gerrit change created: https://git.eclipse.org/r/127717
Gerrit change https://git.eclipse.org/r/127717 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=a6df4005cecee3c34a7818a88218effb6bbdc929
