Bug 535769 - MultiAttributeSWTRenderer reveal should be based on index
Summary: MultiAttributeSWTRenderer reveal should be based on index
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.17.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.18.0   Edit
Assignee: Johannes Faltermeier CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2018-06-11 09:52 EDT by Johannes Faltermeier CLA
Modified: 2018-06-28 03:58 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Faltermeier CLA 2018-06-11 09:52:26 EDT 
Currently the selection is preserved based on index, however the following reveal still falls back to an equals comparison which might result in a different object being revealed.
Comment 1 Eclipse Genie CLA 2018-06-11 09:54:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/124346
Comment 2 Johannes Faltermeier CLA 2018-06-13 03:51:54 EDT 
TEST INFORMATION

This bug targets the reveal logic in the MultiAttributeSWTRenderer. For non-unique list, the first matching element was revealed instead of the moved one. 

Potential regressions
- Problems during move in multi attribute renderer

Things that shall be tested:
Moving and reveal
Comment 4 Eclipse Genie CLA 2018-06-26 10:55:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/125044
Comment 5 Eclipse Genie CLA 2018-06-28 03:58:09 EDT 
Gerrit change https://git.eclipse.org/r/125044 was merged to [feature_528690_commandmonitoring].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=6dbe107ab784f1bb3f1c0fc3a308ee06223d48db