Bug 535673 - Model inferrer instantiates XbaseEvaluator instances
Summary: Model inferrer instantiates XbaseEvaluator instances
Status: RESOLVED FIXED
Alias: None
Product: Viatra
Classification: Modeling
Component: Query (show other bugs)
Version: 2.0.0   Edit
Hardware: Macintosh Mac OS X
: P3 normal
Target Milestone: 2.0.1   Edit
Assignee: Zoltan Ujhelyi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-08 03:51 EDT by Zoltan Ujhelyi CLA
Modified: 2018-07-03 16:12 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Ujhelyi CLA 2018-06-08 03:51:24 EDT
I have seen that the method `BodyCodeGenerator#acceptExpressionEvaluator` instantiates an instance XBaseEvaluator. This is plainly unnecessary here, as the Xbase generator is used there; on the other hand, it can be expensive as it requires (1) locating the Java project metadata for the current object, and (2) initializing a URLClassLoader for that project. We should remove this call here, and replace its usages with the corresponding static method calls.
Comment 1 Eclipse Genie CLA 2018-06-08 10:51:41 EDT
New Gerrit change created: https://git.eclipse.org/r/124263
Comment 3 Eclipse Genie CLA 2018-07-03 10:47:53 EDT
New Gerrit change created: https://git.eclipse.org/r/125403
Comment 5 Zoltan Ujhelyi CLA 2018-07-03 16:12:58 EDT
Fixed in master and backported to 2.0-maintenance.