Bug 535122 - Launch configuration 'Main' tab: Show the value for the Default Java command
Summary: Launch configuration 'Main' tab: Show the value for the Default Java command
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.8 RC4   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-25 10:14 EDT by Vikas Chandra CLA
Modified: 2018-06-06 04:10 EDT (History)
3 users (show)

See Also:
Vikas.Chandra: review+
sarika.sinha: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vikas Chandra CLA 2018-05-25 10:14:57 EDT 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=534579#c0

1) It was good if PDE also shows default({0}) as the text ( that would show as default ( javaw)  if default is not overridden ) just like java application ( jre tab - clicking on alternate JRE).


2) "And (not for 4.8) we should also allow the user to specify the command"

This work depends on the investigation of bug 534579
Comment 1 Dani Megert CLA 2018-06-04 09:19:48 EDT 
(In reply to Vikas Chandra from comment #0)
> See https://bugs.eclipse.org/bugs/show_bug.cgi?id=534579#c0
> 
> 1) It was good if PDE also shows default({0}) as the text ( that would show
> as default ( javaw)  if default is not overridden ) just like java
> application ( jre tab - clicking on alternate JRE).

This is easy to do, see bug 534579 comment 7.

 
> 2) "And (not for 4.8) we should also allow the user to specify the command"
> 
> This work depends on the investigation of bug 534579

Let's do this when we get a concrete request.
Comment 2 Eclipse Genie CLA 2018-06-04 09:26:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/123926
Comment 3 Eclipse Genie CLA 2018-06-05 06:05:02 EDT 
Gerrit change https://git.eclipse.org/r/123926 was merged to [R4_8_maintenance].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=060b9e70c2d58a26adcb0908a86d3d44aa34d2a7
Comment 4 Dani Megert CLA 2018-06-05 06:18:37 EDT 
Cherry-picked the fix to 4.9 with http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=721e164ffe294a6b357f629c68582bdfc4944cec
Comment 5 Dani Megert CLA 2018-06-06 04:10:11 EDT 
Verified in eclipse-SDK-I20180605-2000-win32-x86_64.