Bug 534829 - Add an additional menu to enable the regex mode on tables
Summary: Add an additional menu to enable the regex mode on tables
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: 1.21.0   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy, test
Depends on:
Blocks:
 
Reported: 2018-05-17 11:58 EDT by Eugen Neufeld CLA
Modified: 2019-05-16 11:07 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugen Neufeld CLA 2018-05-17 11:58:01 EDT 
Features is configured OFF in TableBuilder API by default
In the Table Renderer the Feature is explicitly enabled though.
Comment 1 Eugen Neufeld CLA 2018-08-22 09:35:47 EDT 
Mass Move due to time constraints
Comment 2 Eugen Neufeld CLA 2018-11-06 04:40:59 EST 
Mass move to 1.20 due to time constraints.
Comment 3 Eclipse Genie CLA 2019-05-01 12:16:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/141469
Comment 5 Christian Damus CLA 2019-05-02 11:06:29 EDT 
(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/141469 was merged to [develop].

This patch changes the label of the existing filtering menu action from "Toggle filter controls" to "Show filter controls".  This may require changes in automated UI tests and/or user documentation.
Comment 6 Christian Damus CLA 2019-05-06 10:50:56 EDT 
The fix is published in the 1.21 M3 build.
Comment 7 Eclipse Genie CLA 2019-05-14 07:46:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/142123
Comment 9 Jonas Helming CLA 2019-05-16 06:05:13 EDT 
Shouldn't this be tagged with "noteworthy" as it is a new feature?
Comment 10 Christian Damus CLA 2019-05-16 11:07:20 EDT 
Table renderers can now be configured with a regular expression filtering capability in addition to the existing substring filter.  The Nebula Grid renderer enables this filter option by default.

When this new filtering option is enabled, the context menu in the table control shows a new "Show regex filter controls" action.  That and the "Show filter controls" action (for substring filtering; this is renamed from "Toggle filter controls" because filtering is no longer a binary toggle) are now mutually exclusive menu options with a check-mark indicating which (if any) is active.  Filtering uses the same field under the column header in both cases (as previously for substring filtering).

Selecting either filter option in the context menu clears the filter fields and switches filtering to that mode.  Selecting again the active (checked) filter option turns filtering off and hides the filter fields.

Use the TableViewerSWTBuilder::columnRegexFilter(boolean) or TableConfigurationBuilder::columnRegexFilter(boolean) API to enable or disable regular expression filtering for all columns in the table.  Use the ColumnConfigurationBuilder::regexFilter(boolean) API to enable or disable regular expression filtering for a specific column.

Limitations:

Currently, content-assist for regular expression syntax is not provided. When the filter field contains an invalid expression, the filter is considered as though blank (showing all rows of the table); no other indication of syntax problem is presented.  These may be considerations for future enhancement.