Community
Participate
Working Groups
https://github.com/eclipse-ee4j/jaxrs-api/pull/624 -- The IP check says that ggam's signed-off-by is invalid, but actually is valid IMHO.
I tried some variants, and here is the result: SUCCESS: Signed-off-by: Markus Karg <markus@headcrashing.eu> SUCCESS: Signed-off-by: XXX <markus@headcrashing.eu> ERROR: Signed-off-by: XXX <z06.guillermo@gmail.com> SUCCESS: Signed-off-by: Guillermo González de Agüero <markus@headcrashing.eu> SUCCESS: Signed-off-by: Guillermo González de Agüero and Markus KARG <markus@headcrashing.eu> ERROR: Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com> So it seems that umlauts and accents in the full name play no rule, but it is solely the address z06.guillermo@gmail.com which is rejected. Maybe this helps the webmasters in finding the origin of the problem.
The problem still exists, and it is every more strange than before. There was a commit that passed an IP-validation before. I cherry-picked it. And now that commit fails the IP-validation. Again it is a commit from Guillermo! My personal assumption is that the ip-validation bot is not able to deal with UNICODE, because in UNICODE there can be *different* codepoints for the "á" and "ü". Maybe git is rewriting from ASCII to UNICODE or vice versa, and the bot fails because of that?
Any news on this?
We have the same situation again: https://github.com/eclipse-ee4j/jaxrs-api/pull/696 That PR contains a single PR. The Author: is equal to the Signed-off-by: but the ip validation fails with "The following users have invalid Signed-off-by footers. Please use the Signed-Off-By (git commit -s) mechanism to confirm the origin of the submission. The identity in the Signed-off-By must match the Author or the Committer. tareqhs" (see https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=5be853f7b268a). Please either tell us what Tareq's fault is, or fix that annoying bug of the IP validation bot. :-(
(In reply to Markus Karg from comment #4) > We have the same situation again: > > https://github.com/eclipse-ee4j/jaxrs-api/pull/696 > > That PR contains a single PR. The Author: is equal to the Signed-off-by: but > the ip validation fails with "The following users have invalid Signed-off-by > footers. Please use the Signed-Off-By (git commit -s) mechanism to confirm > the origin of the submission. The identity in the Signed-off-By must match > the Author or the Committer. tareqhs" (see > https://dev.eclipse.org/eclipse-webhook/services/status_details. > php?id=5be853f7b268a). > > Please either tell us what Tareq's fault is, or fix that annoying bug of the > IP validation bot. :-( I believe this won't be an issue with the new version of the ECA Validation service which we are working on with Bug 540694 - Github IP validation needs to be more robust.
(In reply to Christopher Guindon from comment #5) > (In reply to Markus Karg from comment #4) > > We have the same situation again: > > > > https://github.com/eclipse-ee4j/jaxrs-api/pull/696 > > > > That PR contains a single PR. The Author: is equal to the Signed-off-by: but > > the ip validation fails with "The following users have invalid Signed-off-by > > footers. Please use the Signed-Off-By (git commit -s) mechanism to confirm > > the origin of the submission. The identity in the Signed-off-By must match > > the Author or the Committer. tareqhs" (see > > https://dev.eclipse.org/eclipse-webhook/services/status_details. > > php?id=5be853f7b268a). > > > > Please either tell us what Tareq's fault is, or fix that annoying bug of the > > IP validation bot. :-( > > I believe this won't be an issue with the new version of the ECA Validation > service which we are working on with Bug 540694 - Github IP validation needs > to be more robust. Closing this bug!
