Community
Participate
Working Groups
This means the following: * it should follow the 2/3 column layout. Currently it uses a 1/2 layout * the label should be one label rather than a composite consisting of multiple labels. The main reason for this is to enable the label's template style properties in a nice way
New Gerrit change created: https://git.eclipse.org/r/122029
REGRESSION INFORMATION Summary of the critical part of the change: * Some code was moved from AbstractControlSWTRenderer/SimpleControlSWTRenderer to AbstractControlSWTRendererUtil/SimpleControlSWTRendererUtil * CompoundControlSWTRenderer GridDescription changed from 1/2 to 2/3 to behave like regular control. * CompoundControlSWTRenderer Label changed to single label from composite of multiple labels * CompoundControlSWTRenderer has additional grid cell (see above) which will either render the validation icon of the first control (which is then not rendered in the controls grid cell) or a dummy validation cell which will remain empty * CompoundControlSWTRenderer API changed (one method removed, additional constructor argument) Potential regressions: * If error was made during code move any control renderer may misbehave * Subclasses of CompoundControlSWTRenderer need to be adapted due to different API, gridcells, and label creation Affected areas / use cases * all control * CompoundControlSWTRenderer Things that shall be tested * Smoke test that controls look fine * CompoundControlSWTRenderer overall
Gerrit change https://git.eclipse.org/r/122029 was merged to [develop]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=4fa398a9a8edf3502a6bf88dfe11b9f22ac0470d
New Gerrit change created: https://git.eclipse.org/r/122237
Gerrit change https://git.eclipse.org/r/122237 was merged to [feature_528690_commandmonitoring]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=62ac7e601ba6910a63e8581d7b233418d578320a