Bug 534267 - CompoundControlSWTRenderer should work similar to SimpleControlSWTRenderer
Summary: CompoundControlSWTRenderer should work similar to SimpleControlSWTRenderer
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.16.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.17.0   Edit
Assignee: Johannes Faltermeier CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2018-05-02 10:15 EDT by Johannes Faltermeier CLA
Modified: 2018-06-14 05:53 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Faltermeier CLA 2018-05-02 10:15:29 EDT
This means the following:
* it should follow the 2/3 column layout. Currently it uses a 1/2 layout
* the label should be one label rather than a composite consisting of multiple labels. The main reason for this is to enable the label's template style properties in a nice way
Comment 1 Eclipse Genie CLA 2018-05-02 11:30:55 EDT
New Gerrit change created: https://git.eclipse.org/r/122029
Comment 2 Johannes Faltermeier CLA 2018-05-02 11:46:27 EDT
REGRESSION INFORMATION

Summary of the critical part of the change:
* Some code was moved from AbstractControlSWTRenderer/SimpleControlSWTRenderer to AbstractControlSWTRendererUtil/SimpleControlSWTRendererUtil
* CompoundControlSWTRenderer GridDescription changed from 1/2 to 2/3 to behave like regular control. 
* CompoundControlSWTRenderer Label changed to single label from composite of multiple labels
* CompoundControlSWTRenderer has additional grid cell (see above) which will either render the validation icon of the first control (which is then not rendered in the controls grid cell) or a dummy validation cell which will remain empty
* CompoundControlSWTRenderer API changed (one method removed, additional constructor argument)

Potential regressions:
* If error was made during code move any control renderer may misbehave
* Subclasses of CompoundControlSWTRenderer need to be adapted due to different API, gridcells, and label creation

Affected areas / use cases
* all control
* CompoundControlSWTRenderer

Things that shall be tested
* Smoke test that controls look fine
* CompoundControlSWTRenderer overall
Comment 4 Eclipse Genie CLA 2018-05-07 04:02:56 EDT
New Gerrit change created: https://git.eclipse.org/r/122237
Comment 5 Eclipse Genie CLA 2018-05-07 05:22:46 EDT
Gerrit change https://git.eclipse.org/r/122237 was merged to [feature_528690_commandmonitoring].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=62ac7e601ba6910a63e8581d7b233418d578320a