Bug 534233 - JDIThread shouldDoExtraStepInto can incorrectly return true when default stratum is not Java
Summary: JDIThread shouldDoExtraStepInto can incorrectly return true when default stra...
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-01 08:14 EDT by Alan Staves CLA
Modified: 2022-08-24 08:01 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Staves CLA 2018-05-01 08:14:01 EDT
If the locations being compared in JDIThread.shouldDoExtraStepInto(Location) have the same default stratum line numbers (when the default stratum of the class is not Java) and are located in different source files (location.sourceName() is different) the shouldDoExtraStepInto incorrectly returns true causing an extra step to be performed when it should not. 

I think lineNumber(JAVA_STRATUM_CONSTANT) should be tested instead of checking the default stratum value. There appears to be a second instance of this in JDIThread.handlEvent for STEP_OVER.
Comment 1 Eclipse Genie CLA 2020-08-08 08:12:43 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Alan Staves CLA 2020-08-10 06:07:28 EDT
This is still an, I have checked the code I mentionned in JDIThread and it is still not referencing JAVA_STRATUM_CONSTANT so will still fail in the same way I described when a different default stratum is used.
Comment 3 Eclipse Genie CLA 2022-08-23 04:49:27 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Alan Staves CLA 2022-08-24 07:51:06 EDT
This is still an issue, the methods have still not been fixed to specify JAVA_STRATUM_CONSTANT.
Comment 5 Andrey Loskutov CLA 2022-08-24 08:01:20 EDT
(In reply to Alan Staves from comment #4)
> This is still an issue, the methods have still not been fixed to specify
> JAVA_STRATUM_CONSTANT.

If you are interested in a fix, please file the issue at https://github.com/eclipse-jdt/eclipse.jdt.debug/issues and propose a PR.