Bug 533839 - Cut/Copy/Paste in Java editor's context menu misses icons
Summary: Cut/Copy/Paste in Java editor's context menu misses icons
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M7   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
Depends on:
Blocks:
 
Reported: 2018-04-19 15:41 EDT by Mickael Istria CLA
Modified: 2018-04-23 08:48 EDT (History)
3 users (show)

See Also:
daniel_megert: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2018-04-19 15:41:43 EDT 
+++ This bug was initially created as a clone of Bug #533729 +++

While Cut/Copy/Paste have icons in the Edit menu, those icons don't appear in the context-menu on Java editor.
Comment 1 Eclipse Genie CLA 2018-04-19 15:44:04 EDT 
New Gerrit change created: https://git.eclipse.org/r/121440
Comment 2 Dani Megert CLA 2018-04-20 10:10:29 EDT 
Why did you create that clone?
Comment 3 Dani Megert CLA 2018-04-20 10:11:38 EDT 
(In reply to Dani Megert from comment #2)
> Why did you create that clone?

Oh, I see it is for the Java editor. Ugly that we have to do this at multiple places.
Comment 4 Mickael Istria CLA 2018-04-20 12:12:35 EDT 
Resetting assignee. I don't plan to spend more time on the proposed patch at the moment. If anyone wants to continue this work, feel free to reuse my patch.
Comment 5 Noopur Gupta CLA 2018-04-23 05:10:10 EDT 
Removing the unnecessary whitespace changes from JavaEditor.java was easy. I just replaced the file with the version in master and copied the two lines of new code from the patch. I have done that in patch set 4. I haven't checked if anything else is pending in the patch.
Comment 6 Mickael Istria CLA 2018-04-23 05:13:57 EDT 
(In reply to Noopur Gupta from comment #5)
> Removing the unnecessary whitespace changes from JavaEditor.java was easy. I
> just replaced the file with the version in master and copied the two lines
> of new code from the patch. I have done that in patch set 4. I haven't
> checked if anything else is pending in the patch.

Thanks a lot Noopur.