Bug 533318 - Add standard diagram services to avoid duplicated code
Summary: Add standard diagram services to avoid duplicated code
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 5.1.0   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 5.1.2   Edit
Assignee: Project Inbox CLA
QA Contact: Laurent Redor CLA
URL:
Whiteboard:
Keywords: triaged
Depends on: 530431
Blocks: 533654 534302
  Show dependency tree
 
Reported: 2018-04-06 10:48 EDT by Laurent Redor CLA
Modified: 2018-06-28 12:10 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2018-04-06 10:48:09 EDT 
+++ This bug was initially created as a clone of Bug #530431 +++

Some services can be defined several times in different modeler defined with Sirius. To avoid them, it could be interesting to have a standard diagram services class, as it is the case for Sirius Core (org.eclipse.sirius.common.tools.api.interpreter.StandardServices).

In a first time, this class could contain services to retreive DDiagramElement according to:
* the type of the current selected elements
* the mapping of the current selected elements
* a selected type by the end-user
* an expression given by the end-user
Comment 1 Eclipse Genie CLA 2018-04-17 11:56:11 EDT 
New Gerrit change created: https://git.eclipse.org/r/121276
Comment 3 Eclipse Genie CLA 2018-04-27 11:10:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/121883
Comment 5 Laurent Redor CLA 2018-04-27 11:21:13 EDT 
Currently, the work on this POC is interrupted. The first iteration is considered as ended.
Comment 6 Laurent Redor CLA 2018-05-16 04:47:26 EDT 
To finalize the POC, it would be interesting to handle the below points:
* Currently, the service stdGetViewsRepresentingSelectedType returns the list of DSemanticDecorator in the current diagram representing semantic element having the EType provided by the end-user through a dialog box. But the field in the dialog box has not completion. It is a simple text field.
	* It would be useful to have a completion about all ETypes of the meta-model known by the current diagram.
* Currently, the service stdGetViewsOfExpression returns the list of DSemanticDecorator corresponding to the evaluation of an expression written by the end-user in a dialog box.But the field in the dialog box has not completion, neither validation. It is a simple text field.
	* It would be useful to have a completion and validation as if the end-user uses the Interpreter view.
	* It would be also useful to add several variables (diagram for the current diagram, selectedViews for all the selected views, ...)
Comment 7 Laurent Redor CLA 2018-05-31 11:30:56 EDT 
Another issue will be created to continue the work on this subject. So I close this issue as resolved.
Comment 8 Laurent Redor CLA 2018-05-31 11:31:29 EDT 
There is no real validation as it is a POC.
Comment 9 Laurent Redor CLA 2018-06-28 12:10:52 EDT 
Available in Sirius 5.1.2, see https://wiki.eclipse.org/Sirius/5.1.2 for details