Bug 533299 - No Template Model Migration
Summary: No Template Model Migration
Status: RESOLVED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.16.0   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 1.18.0   Edit
Assignee: Lucas Koehler CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2018-04-06 04:23 EDT by Johannes Faltermeier CLA
Modified: 2018-06-14 05:53 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Faltermeier CLA 2018-04-06 04:23:52 EDT
With 1.17.0 we change the NS-URI of the core view model. This will make DMR-Selectors invalid, so we also need a migration for template models. 

As a remark: The EdaptViewModel migrator also has API to migrate a string
Comment 1 Eclipse Genie CLA 2018-04-24 09:40:02 EDT
New Gerrit change created: https://git.eclipse.org/r/121661
Comment 2 Lucas Koehler CLA 2018-06-07 05:21:46 EDT
For a proper migration, the following steps would be necessary:
- Create an EdaptTemplateModelMigrator similar to the EdaptViewModelMigrator
- Therefore, extract common functionality from the EdaptViewModelMigrator to a common class
- Integrate check in the TemplateModelEditorPart that checks whether a migration is necessary, and if yes prompts the user about this (see ViewEditorPart)
- Add test cases: RCPTT and/or plugin test

Estimated development time: 5 days (3-6 days)
Comment 3 Lucas Koehler CLA 2018-06-07 05:23:27 EDT
Addition: For o histories should be needed for the template model elements. Instead they can be generated on the fly (functionality is present in the EdaptViewModelMigrator)
Comment 4 Lucas Koehler CLA 2018-06-07 05:24:27 EDT
*For now, no histories should be needed for the template model elements.
Comment 5 Eclipse Genie CLA 2018-06-08 06:19:59 EDT
New Gerrit change created: https://git.eclipse.org/r/124244
Comment 7 Lucas Koehler CLA 2018-06-08 09:46:16 EDT
REGRESSION INFORMATION:
If the user accepts migrating the opened view model, the view model editor additionally asks the user if (s)he wants to migrate template models in the workspace.
If a template model needs migration, the template model editor prompts the user whether it should be migrated. If the user accepts, the editor additionally prompts whether template models in the workspace should be migrated.


Follow up task for refactoring the migration of view- and template models: Bug 535685