Community
Participate
Working Groups
Text is bit hard to read in dark theme if the code is not covered by the Eclemma. Plz make the red a bit more lighter, when Eclipse is in Dark theme. I Pretty much can't see anything if it is a Scala code.
Created attachment 273452 [details] screenshot for scala code with intellij-style theme
(In reply to chidveer chinthakuntla from comment #0) > Text is bit hard to read in dark theme if the code is not covered by the > Eclemma. > Plz make the red a bit more lighter, when Eclipse is in Dark theme. > I Pretty much can't see anything if it is a Scala code. Do you know that this is configurable - see "Highlighting Preferences" at https://help.eclipse.org/oxygen/topic/org.eclipse.eclemma.doc/pages/annotations.html?cp=24_0_2 ?
Yes, If you can auto-configure it for "Dark Theme", will help user-experience.
(In reply to chidveer chinthakuntla from comment #3) > If you can auto-configure it for "Dark Theme", will help user-experience. Here is PR that adjusts default colors in Dark theme with id "org.eclipse.e4.ui.css.theme.e4_dark": https://github.com/eclipse/eclemma/pull/24 However (In reply to chidveer chinthakuntla from comment #1) > screenshot for scala code with intellij-style theme I don't know what do you mean by "intellij-style theme" and I don't use Scala. Thus will be really helpful and appreciated if you can test this PR and provide us feedback or at least describe more precisely how we can test your scenario.
You can ignore that comment. I was trying to say that... The Scala Code in Eclipse-Dark theme will be pretty much unreadable. In My screenshot it look good so, i said that, i used EclipseColorTheme plugin and changed the fonts colors. I should have attached the java code screenshot.
(In reply to chidveer chinthakuntla from comment #5) > You can ignore that comment. Ok, I ignore previous comment, but unfortunately the last one also doesn't look clear to me: > I was trying to say that... > The Scala Code in Eclipse-Dark theme will be pretty much unreadable. In My > screenshot it look good so, i said that, i used EclipseColorTheme plugin and > changed the fonts colors. will the above PR work for you? for Scala? for Java? or it will not because PR is about "org.eclipse.e4.ui.css.theme.e4_dark" while you use "EclipseColorTheme plugin"? > I should have attached the java code screenshot. PR includes screenshots before and after for the case of Java.
I didn't play around with building and running eclipse/modules. (In reply to Evgeny Mandrikov from comment #6) > (In reply to chidveer chinthakuntla from comment #5) > > You can ignore that comment. > > Ok, I ignore previous comment, but unfortunately the last one also doesn't > look clear to me: > > > I was trying to say that... > > The Scala Code in Eclipse-Dark theme will be pretty much unreadable. In My > > screenshot it look good so, i said that, i used EclipseColorTheme plugin and > > changed the fonts colors. > > will the above PR work for you? for Scala? for Java? or it will not because > PR is about "org.eclipse.e4.ui.css.theme.e4_dark" while you use > "EclipseColorTheme plugin"? > > > I should have attached the java code screenshot. > > PR includes screenshots before and after for the case of Java. I didn't play around with this plugin build/run. I think you can go-ahead with the PR, if i see any issue in future i'll create an other ticket.
(In reply to chidveer chinthakuntla from comment #7) > I didn't play around with this plugin build/run. You can install pre-built from this temporary location: http://download.eclipse.org/eclemma/bugzilla-533264/
Created attachment 274679 [details] CoverageTest video The uncovered lines are not highlighted, is it intended ?. Also, the SomeSillyClass in the video is red; isn't supposed to be yellow ?
Created attachment 274682 [details] SourceCode
(In reply to chidveer chinthakuntla from comment #9) > Created attachment 274679 [details] > CoverageTest video > > The uncovered lines are not highlighted, is it intended ?. > Also, the SomeSillyClass in the video is red; isn't supposed to be yellow ? Excuse me, but how this relates to the topic? You see exactly the same result as before, for latest released EclEmma version 3.1.0: Eclipse Java Compiler does not produce bytecode for dead code constructions such as "if (false) ...", so in this case there is no "uncovered lines" since there is no lines at all, hence correctly no highlighting at all. Line "public class SomeSillyClass" is not about content of class as a whole - it is line of implicit public constructor without arguments, which is never invoked, hence correctly marked as uncovered. Either invoke it, or add explicit private constructor without arguments indicating that it is not intended to be invoked and hence won't be part of coverage analysis. --- Topic started from your screenshot with Scala (comment #1) and was continued about Scala (comment #4), being the main question and my concern here - no concerns about Java since I use it, while don't use Scala (comment #4).
Created attachment 274699 [details] Screenshot for coverage on the scala code > Eclipse Java Compiler does not produce bytecode for dead code constructions > such as "if (false) ...", so in this case there is no "uncovered lines" > since there is no lines at all, hence correctly no highlighting at all. I didn't know that. Now its much better.
Thank you for testing. Change was merged into master and will be part of our next release.
