Bug 53323 - Make implementations of Addr2Line and CPPFile extendable
Summary: Make implementations of Addr2Line and CPPFile extendable
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Alain Magloire CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2004-02-27 16:19 EST by uwe CLA
Modified: 2008-06-18 18:06 EDT (History)
0 users

See Also:

Attachments
Synchronize implementations of Addr2line/CPPFilt/Objdump to be extendable (4.28 KB, patch)
2004-02-27 16:47 EST, uwe CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description uwe CLA 2004-02-27 16:19:03 EST 
Right now, both class implemenations uses a hardcoded set of default options 
to call the underlaying 'addr2line' and 'c++filt' utilities. If anything goes 
wrong calling the tools, the constructor of these classes throws an exception 
which stops the instanciation of these classes. The implementation of both 
classes make it impossible to extend the functionality and adjust the command 
line to the need of specific toolchains requiring different command line 
options to call both tools successfully. A more flexible implementation the 
one of the Objdump would be highly welcome.
Comment 1 uwe CLA 2004-02-27 16:47:59 EST 
Created attachment 8228 [details]
Synchronize implementations of Addr2line/CPPFilt/Objdump to be extendable
Comment 2 uwe CLA 2004-02-27 16:51:59 EST 
Objdump.init(...) used default package visibility. To allow the possiblity of 
changing command line parameters for objdump by contributors (plugins) outside 
of CDT, the visibility of Objdump.init(...) needs to be at least protected.
Comment 3 Alain Magloire CLA 2004-02-27 17:00:37 EST 
Ok the patch looks good, let me get back to you on Monday.
Comment 4 Alain Magloire CLA 2004-03-01 10:22:04 EST 
Fix in the head.  Thanks for the patch.